Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spaCy 2.2.3 and required dependency updates #73912

Merged
merged 3 commits into from Nov 24, 2019
Merged

Conversation

@danieldk
Copy link
Member

@danieldk danieldk commented Nov 22, 2019

Motivation for this change

Changelog:

https://github.com/explosion/spaCy/releases/tag/v2.2.3

This update also requires a new derivation, catalogue, and a version bump to the wasabi derivation. These changes are bundled in this PR.

Tested using the small English model.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@danieldk danieldk requested review from FRidh and jonringer as code owners Nov 22, 2019
@danieldk
Copy link
Member Author

@danieldk danieldk commented Nov 22, 2019

@GrahamcOfBorg build python3Packages.spacy

Copy link
Contributor

@jonringer jonringer left a comment

nix-review passes on NixOS (failures are unrelated to PR)
diff LGTM
commits LGTM

[14 built (1 failed), 58 copied (124.0 MiB), 24.4 MiB DL]
error: build of '/nix/store/7m40pcb7rlln9sx8x4nxfihcgdccqbn0-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73912
2 package failed to build:
python38Packages.spacy python38Packages.textacy

11 package were built:
python27Packages.catalogue python27Packages.thinc python27Packages.wasabi python37Packages.catalogue python37Packages.spacy python37Packages.textacy python37Packages.thinc python37Packages.wasabi python38Packages.catalogue python38Packages.thinc python38Packages.wasabi
@jonringer jonringer merged commit ba718f5 into NixOS:master Nov 24, 2019
15 checks passed
15 checks passed
python3Packages.spacy on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python3Packages.spacy on x86_64-linux Success
Details
@danieldk danieldk deleted the danieldk:spacy-2.2.3 branch Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.