Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HaskellNet, HaskellNet-SSL: jailbreak to fix dependencies versions #73913

Closed
wants to merge 26 commits into from

Conversation

@ghost
Copy link

@ghost ghost commented Nov 22, 2019

HaskellNet, HaskellNet-SSL: jailbreak to fix dependencies versions

peti and others added 18 commits Nov 4, 2019
This update was generated by hackage2nix v2.15.0-7-gbb66e86 from Hackage revision
commercialhaskell/all-cabal-hashes@cbaa5be.
William R. Arellano
haskellPackages.hail: add patches to relax cabal dependencies
hapistrano: fix broken package
This update was generated by hackage2nix v2.15.0-7-gbb66e86 from Hackage revision
commercialhaskell/all-cabal-hashes@2e34643.
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@271bac6.
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@842879f.
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@46b21fd.
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@b8c1570.
haskellPackages.hakyll-images: unmark as broken
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@3230b5e.
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@36155b6.
@ghost ghost requested review from basvandijk and cdepillabout as code owners Nov 22, 2019
@ghost ghost changed the title Haskell updates HaskellNet, HaskellNet-SSL: jailbreak to fix dependencies versions Nov 22, 2019
tjilerom and others added 4 commits Nov 22, 2019
tjilerom
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@0664ab5.
tjilerom
@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Nov 22, 2019

@tjilerom Thanks for sending this PR.

Could you rebase this on top of haskell-updates so the history is easy to understand?

tjilerom added 2 commits Nov 22, 2019
Copy link
Member

@peti peti left a comment

Please commit unrelated whitespace changes.

@@ -142,26 +142,26 @@ self: super: {
vector = dontCheck (if pkgs.stdenv.isi686 then appendConfigureFlag super.vector "--ghc-options=-msse2" else super.vector);

conduit-extra = if pkgs.stdenv.isDarwin
then super.conduit-extra.overrideAttrs (drv: { __darwinAllowLocalNetworking = true; })
else super.conduit-extra;
then super.conduit-extra.overrideAttrs (drv: { __darwinAllowLocalNetworking = true; })

This comment has been minimized.

@peti

peti Nov 29, 2019
Member

Could you please explain a bit what this addition is about? Why is that attribute required?

then dontCheck (overrideCabal super.hakyll (drv: {
testToolDepends = [];
}))
else super.hakyll;
Comment on lines +157 to +160

This comment has been minimized.

@peti

peti Nov 29, 2019
Member

What is this change about? This looks like you're changing only whitespace.

then super.double-conversion
else addExtraLibrary super.double-conversion pkgs.libcxx;
Comment on lines +163 to +164

This comment has been minimized.

@peti

peti Nov 29, 2019
Member

ditto

@peti peti force-pushed the NixOS:haskell-updates branch 4 times, most recently from b7e2d3e to 2ad2f5a Nov 29, 2019
@FRidh FRidh added this to WIP in Staging Dec 1, 2019
@peti peti force-pushed the NixOS:haskell-updates branch 4 times, most recently from 7d9226e to 53dca0d Dec 6, 2019
@peti peti force-pushed the NixOS:haskell-updates branch 2 times, most recently from 3814616 to 8bee1b9 Dec 13, 2019
@peti peti force-pushed the NixOS:haskell-updates branch 5 times, most recently from aa46cdd to fdd64fb Dec 20, 2019
@peti
Copy link
Member

@peti peti commented Jan 5, 2020

Closing because of inactivity.

@peti peti closed this Jan 5, 2020
Staging automation moved this from WIP to Done Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.