Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nebula: init at 1.0.0 #73918

Merged
merged 1 commit into from Dec 1, 2019
Merged

nebula: init at 1.0.0 #73918

merged 1 commit into from Dec 1, 2019

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 22, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@erikarvstedt

This comment has been minimized.

Copy link
Member

erikarvstedt commented Nov 28, 2019

Tested ACK 0de9969

sha256 = "0j7fna352z8kzx6n0hck7rp122c0v44j9syz0v30vq47xq2pwj5c";
};

modSha256 = "130h0gc5z0w5inpc99y6mismwg3nyzk3bqdq5v9yclkxlhkbcp6d";

This comment has been minimized.

Copy link
@coderobe

coderobe Nov 30, 2019

This modSha256 does not match up with what i'm getting

This comment has been minimized.

Copy link
@kalbasit

kalbasit Dec 1, 2019

Member

build passed on ofborg.

@kalbasit

This comment has been minimized.

Copy link
Member

kalbasit commented Nov 30, 2019

@GrahamcOfBorg build nebula

@kalbasit kalbasit merged commit 509b20a into NixOS:master Dec 1, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nebula on aarch64-linux Success
Details
nebula on x86_64-darwin Success
Details
nebula on x86_64-linux Success
Details
@devhell

This comment has been minimized.

Copy link
Contributor

devhell commented Dec 1, 2019

Would this ideally benefit from a service as well?

@coderobe

This comment has been minimized.

Copy link

coderobe commented Dec 1, 2019

upstream is working on that, better just wait on the next upstream release.

@filalex77

This comment has been minimized.

Copy link
Contributor Author

filalex77 commented Dec 1, 2019

@devhell Just as @coderobe said: as soon as they get the service done, I'll publish my draft of the service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.