Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r19.09]: python27Packages.cherrypy: fix build #73920

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Nov 22, 2019

Motivation for this change

Due to the recent update of python 2.7 from 2.7.16 to 2.7.17 (see 05dfc50) the StaticTest::test_null_bytes test case started failing on 2.7 too.

This is because additional validation has been backported to httplib in PR 13315 in https://github.com/python/cpython to to address a security issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Due to the recent update of python 2.7 from 2.7.16 to 2.7.17
(see 05dfc50) the
`StaticTest::test_null_bytes` test case started failing on 2.7
too.

This is because additional validation has been backported to
httplib in PR 13315 in https://github.com/python/cpython to
to address a security issue.
@FRidh
Copy link
Member

@FRidh FRidh commented Nov 22, 2019

Has this been fixed already on master? Different fix here?

@d-goldin d-goldin mentioned this pull request Nov 22, 2019
1 of 10 tasks complete
@d-goldin
Copy link
Contributor Author

@d-goldin d-goldin commented Nov 22, 2019

@FRidh: I was about to do a PR for master too, but then encountered some issue that prevents building entirely;

#73922

> nix-build -I nixpkgs=$(pwd) '<nixpkgs>' -A pkgs.pythonPackages.cherrypy

error: black-19.10b0 not supported for interpreter python2.7
(use '--show-trace' to show detailed location information)

So I'm looking into that for a minute.

@d-goldin d-goldin mentioned this pull request Nov 22, 2019
1 of 10 tasks complete
@d-goldin
Copy link
Contributor Author

@d-goldin d-goldin commented Nov 26, 2019

@FRidh: I think it would be nice to merge this one for 19.09 as work on deprecating the 2.7 version is going on (#73927) and this has a few downstream failures.

Copy link
Contributor

@Lassulus Lassulus left a comment

well, everything builds with nix-review, so it should work?

@Lassulus Lassulus merged commit 9501ac3 into NixOS:release-19.09 Nov 26, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.cherrypy on aarch64-linux Success
Details
python27Packages.cherrypy on x86_64-darwin Success
Details
python27Packages.cherrypy on x86_64-linux Success
Details
@d-goldin d-goldin deleted the d-goldin:fix_py27_cherrypy branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.