Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP python27Packages.cherrypy: fix build #73922

Closed
wants to merge 1 commit into from

Conversation

@d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Nov 22, 2019

Motivation for this change

Due to the recent update of python 2.7 from 2.7.16 to 2.7.17 (see 05dfc50) the StaticTest::test_null_bytes test case started failing on 2.7 too.

This is because additional validation has been backported to httplib in PR 13315 in https://github.com/python/cpython to to address a security issue.

(cherry picked from commit 1295a8e)

Note: This is currently not building due to some other issue involving pytest-black.

Backport: #73920

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Due to the recent update of python 2.7 from 2.7.16 to 2.7.17
(see 05dfc50) the
`StaticTest::test_null_bytes` test case started failing on 2.7
too.

This is because additional validation has been backported to
httplib in PR 13315 in https://github.com/python/cpython to
to address a security issue.

(cherry picked from commit 1295a8e)
@d-goldin d-goldin requested review from FRidh and jonringer as code owners Nov 22, 2019
@d-goldin d-goldin mentioned this pull request Nov 22, 2019
3 of 10 tasks complete
@d-goldin d-goldin changed the title python27Packages.cherrypy: fix build WIP python27Packages.cherrypy: fix build Nov 22, 2019
@d-goldin
Copy link
Contributor Author

@d-goldin d-goldin commented Nov 22, 2019

Seems like maybe the world has just moved on...
black requires python3.6 (brought in via portend), which is fixable by only including pytest-black for newer versions, but also webtest fails due to pastedeploy not working for 2.7 anymore.

@FRidh: I think it might be worth considering to just ditch cherrypy for 2.7 alltogether, as 2.7 will be EOL by the time of next release.

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 22, 2019

@d-goldin that's up to the maintainer of the expression. I'm all for it.

@d-goldin
Copy link
Contributor Author

@d-goldin d-goldin commented Nov 22, 2019

@FRidh: Alright, then I'll make a PR for removal and let's see what the maintainer says. In any case, we can look at the fix for 19.09 in isolation then for the time being.

@d-goldin
Copy link
Contributor Author

@d-goldin d-goldin commented Nov 22, 2019

Closing in favour of deprecation PR.

@d-goldin d-goldin closed this Nov 22, 2019
@d-goldin d-goldin mentioned this pull request Nov 22, 2019
1 of 10 tasks complete
@d-goldin d-goldin deleted the d-goldin:fix_py27_cherrypy_master branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.