Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python27Packages.cherrypy: deprecating python 2.7 #73927

Closed
wants to merge 1 commit into from

Conversation

@d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Nov 22, 2019

Motivation for this change

A lot of packages have moved on and don't immedaitely support python
2.7 anymore. While it would be possible to patch things up in multiple
corners, python 2.7 is EOL 2020-01-01 so it doesn't seem to be worth it
anymore.

Supersedes: #73922
Related: #73920

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

There is no maintainer set for cherrypy, so not sure whom to ping except for the usual suspects
cc @FRidh @jonringer

From commit log: @dotlambda @johanot @marsam

A lot of packages have moved on and don't immedaitely support python
2.7 anymore. While it would be possible to patch things up in multiple
corners, python 2.7 is EOL 2020-01-01 so it doesn't seem to be worth it
anymore.
@d-goldin d-goldin requested review from FRidh and jonringer as code owners Nov 22, 2019
@FRidh
Copy link
Member

@FRidh FRidh commented Nov 22, 2019

have a quick search on the issue tracker. You'll find those that often mention cherrypy.

@flokli
Copy link
Contributor

@flokli flokli commented Nov 25, 2019

@FRidh I checked nixpkgs for usage of cherrypy with python2:

pkgs/applications/networking/flexget/default.nix # uses python3
pkgs/applications/networking/p2p/tribler/default.nix # uses python2
pkgs/applications/version-management/bugseverywhere/default.nix # uses python2, but: "Upstream stopped development of this package. If this package does not build anymore, feel free to remove it"
pkgs/development/python-modules/WSME/default.nix # no specific versioning
pkgs/development/python-modules/cheroot/default.nix # no specific versioning
pkgs/development/python-modules/cherrypy/default.nix # python3 version (to be kept)
pkgs/development/python-modules/cherrypy/17.nix # python2 version (to be removed)
pkgs/development/python-modules/ws4py/default.nix # no specific versioning
pkgs/development/python-modules/zerobin/default.nix # no specific versioning
pkgs/games/mnemosyne/default.nix # no specific versioning
pkgs/servers/sickbeard/default.nix # python2 only, but from 2016
pkgs/tools/admin/salt/pepper/default.nix # no specific versioning
pkgs/tools/filesystems/ceph/default.nix # python3

I think we should check what of these packages can be moved to python3 by now, but it doesn't look like a too complex thing to solve.

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 25, 2019

@d-goldin
Copy link
Contributor Author

@d-goldin d-goldin commented Nov 25, 2019

I can have a look at some of those packages too.

@d-goldin
Copy link
Contributor Author

@d-goldin d-goldin commented Dec 20, 2019

Closing, because of lack of interest.

@d-goldin d-goldin closed this Dec 20, 2019
@d-goldin d-goldin deleted the d-goldin:remove_cherrypy_py27 branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.