Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx-sso: 0.16.1 -> 0.22.0 #73929

Merged
merged 1 commit into from Nov 25, 2019
Merged

nginx-sso: 0.16.1 -> 0.22.0 #73929

merged 1 commit into from Nov 25, 2019

Conversation

@bbigras
Copy link
Contributor

bbigras commented Nov 22, 2019

Motivation for this change

update nginx-sso

⚠️ Note that I only tested that the binary ran (and I accessed it with a browser to see the login page). I don't use nginx-sso yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

❯ nix path-info -S /nix/store/jhl6867ax44dp8ijvzsw5s3gv5qiccjl-nginx-sso-0.16.1-bin
/nix/store/jhl6867ax44dp8ijvzsw5s3gv5qiccjl-nginx-sso-0.16.1-bin 44707632

❯ nix path-info -S /nix/store/brcbzs0gq0k617q1q40c3ki1nxznccnr-nginx-sso-0.22.0-bin
/nix/store/brcbzs0gq0k617q1q40c3ki1nxznccnr-nginx-sso-0.22.0-bin 51235376

Notify maintainers

cc @delroth

Copy link
Contributor

tomfitzhenry left a comment

LGTM.

@flokli flokli merged commit 2394eb5 into NixOS:master Nov 25, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nginx-sso on aarch64-linux Success
Details
nginx-sso on x86_64-linux Success
Details
@bbigras bbigras deleted the bbigras:nginx-sso branch Nov 25, 2019
@bbigras
Copy link
Contributor Author

bbigras commented Nov 25, 2019

Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.