Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kbfs service: Do not assume fuse is installed #73930

Closed
wants to merge 1 commit into from

Conversation

@maljub01
Copy link
Contributor

@maljub01 maljub01 commented Nov 22, 2019

Motivation for this change

Currently the kbfs service does not work unless fuse is installed as a system package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Nov 22, 2019

Hmm, we've actually hardcoded fusermount in kbfs

But I think this might have had unintended side-effects.
I believe this needs to be suid, which it won't when it's in the /nix/store.
That's why the path here is at /run/wrappers.

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Nov 22, 2019

Also, it's perfectly fine to assume this in NixOS because the following configuration will be applied on every system using NixOS

@maljub01
Copy link
Contributor Author

@maljub01 maljub01 commented Nov 26, 2019

@worldofpeace thanks for the response and explanation.

It seems something is broken in my current setup. I'll close this PR for now while I investigate it.

@maljub01 maljub01 closed this Nov 26, 2019
@maljub01 maljub01 deleted the maljub01:patch-3 branch Nov 26, 2019
@worldofpeace worldofpeace mentioned this pull request Dec 9, 2019
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.