Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.cockroachdb: port to python #73934

Merged
merged 6 commits into from Apr 19, 2020

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Nov 22, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc

@flokli flokli requested a review from fpletz Nov 22, 2019
@flokli flokli force-pushed the flokli:nixos-test-port-cockroachdb branch 2 times, most recently from 8add180 to fb124c5 Nov 22, 2019
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Nov 23, 2019

@GrahamcOfBorg test cockroachdb

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Nov 23, 2019

Seeing sort of failure only on x86_64-linux

/nix/store/fbqss54p4xbj10zi93ywlikgij15adhr-nixos-test-driver/bin/.nixos-test-driver-wrapped:639: DeprecationWarning: invalid escape sequence '\@'
  line = _line.decode("unicode_escape").replace("\r", "").rstrip()
node1 # Error: parse postgresql://root\@192.168.1.1:26257?sslmode=disable: net/url: invalid userinfo
node1: output:
error: command `cockroach workload init bank 'postgresql://root\@192.168.1.1:26257?sslmode=disable'` failed (exit code 1)
Copy link
Member

@worldofpeace worldofpeace left a comment

I believe this is what's causing that issue, this doesn't even need to be escaped.
Tested locally.

nixos/tests/cockroachdb.nix Outdated Show resolved Hide resolved
nixos/tests/cockroachdb.nix Outdated Show resolved Hide resolved
@flokli flokli force-pushed the flokli:nixos-test-port-cockroachdb branch from fb124c5 to 1c9be5c Nov 23, 2019
@flokli
Copy link
Contributor Author

@flokli flokli commented Nov 23, 2019

Argh, 🤦‍♂️. Thanks for spotting that!

@flokli flokli force-pushed the flokli:nixos-test-port-cockroachdb branch 2 times, most recently from e9bd08b to 2419ecc Nov 23, 2019
@tfc
tfc approved these changes Nov 23, 2019
@flokli
Copy link
Contributor Author

@flokli flokli commented Nov 23, 2019

@GrahamcOfBorg test cockroachdb

@flokli flokli requested a review from thoughtpolice as a code owner Nov 23, 2019
@flokli
Copy link
Contributor Author

@flokli flokli commented Nov 23, 2019

For some reason, this still doesn't converge properly here - even though it kinda succeeds in the perl version. 🤔

@flokli
Copy link
Contributor Author

@flokli flokli commented Nov 23, 2019

@GrahamcOfBorg test cockroachdb

@flokli flokli force-pushed the flokli:nixos-test-port-cockroachdb branch from 4fec4bb to 0734591 Dec 6, 2019
@flokli
Copy link
Contributor Author

@flokli flokli commented Dec 6, 2019

@GrahamcOfBorg test cockroachdb

@tfc
Copy link
Contributor

@tfc tfc commented Jan 14, 2020

@flokli what's the state of this?

@flokli
Copy link
Contributor Author

@flokli flokli commented Jan 14, 2020

@tfc tfc mentioned this pull request Feb 13, 2020
3 of 10 tasks complete
node.start()
node.wait_for_unit("cockroachdb")
node1.succeed(
"cockroach sql --host=192.168.1.1 --insecure -e 'SHOW ALL CLUSTER SETTINGS' 2>&1"

This comment has been minimized.

@monoidal

monoidal Apr 2, 2020

IIUIC, this needs , between the strings, otherwise they're concatenated.

This comment has been minimized.

@flokli

flokli Apr 2, 2020
Author Contributor

nice catch! However, I still don't get the servers to sync together. It did eventually succeed!

@flokli flokli force-pushed the flokli:nixos-test-port-cockroachdb branch from 0734591 to fe6dd71 Apr 2, 2020
@flokli
Copy link
Contributor Author

@flokli flokli commented Apr 2, 2020

I rebased this on latest master.

@flokli
Copy link
Contributor Author

@flokli flokli commented Apr 2, 2020

@GrahamcOfBorg test cockroachdb

@flokli
Copy link
Contributor Author

@flokli flokli commented Apr 2, 2020

@tfc this test works now, PTAL.

@worldofpeace worldofpeace requested a review from tfc Apr 8, 2020
@tfc
tfc approved these changes Apr 17, 2020
@worldofpeace worldofpeace merged commit f882896 into NixOS:master Apr 19, 2020
18 checks passed
18 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
cockroachdb, cockroachdb.passthru.tests on aarch64-linux Success
Details
cockroachdb, cockroachdb.passthru.tests on x86_64-darwin Success
Details
cockroachdb, cockroachdb.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fe6dd71"; rev="fe6dd71f72ad53f8556498f6c1fb97f4004df6d5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fe6dd71"; rev="fe6dd71f72ad53f8556498f6c1fb97f4004df6d5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fe6dd71"; rev="fe6dd71f72ad53f8556498f6c1fb97f4004df6d5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fe6dd71"; rev="fe6dd71f72ad53f8556498f6c1fb97f4004df6d5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fe6dd71"; rev="fe6dd71f72ad53f8556498f6c1fb97f4004df6d5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fe6dd71"; rev="fe6dd71f72ad53f8556498f6c1fb97f4004df6d5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fe6dd71"; rev="fe6dd71f72ad53f8556498f6c1fb97f4004df6d5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.cockroachdb on aarch64-linux Success
Details
tests.cockroachdb on x86_64-linux Success
Details
@flokli flokli deleted the flokli:nixos-test-port-cockroachdb branch Apr 19, 2020
@ajs124 ajs124 mentioned this pull request Sep 9, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.