Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.gnome3-xorg: port to python/rewrite #73938

Merged
merged 2 commits into from Jan 8, 2020

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Nov 22, 2019

Motivation for this change

This test unfortunately doesn't work properly with this port.
It fails at the call to

machine.wait_for_unit("gnome-session-x11@gnome.target", "${user.name}")

with error: unit "gnome-session-x11@gnome.target" is inactive and there are no pending jobs.

Also, how I set the default session here is not really what I want.
I wrote #73378 shortly after this because bash... yeah no.

Rebased because that code is now merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

worldofpeace added 2 commits Nov 8, 2019
A lot of tests assume that the alice user
will have a uid of 1000. Let's make that
a guarantee and be able to reference this value.
We've rewritten it use GDM, and we can now autologin
to the X11 session because of the accountsservice preStart
script for autologin. It should work similar to how the wayland
test works, just with a few nuanced differences for xorg.
@worldofpeace worldofpeace force-pushed the worldofpeace:port-gnome3-xorg-test branch from 4bc8e2f to 228818c Dec 22, 2019
@worldofpeace worldofpeace changed the title nixosTests.gnome3-xorg: port to python nixosTests.gnome3-xorg: port to python/rewrite Dec 22, 2019
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Dec 22, 2019

I've made this match the gnome3.nix test because that works reliably. Until the python driver doesn't poll the cli for waiting on systemd units, using them in this test will not work.

@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Dec 22, 2019

@GrahamcOfBorg test gnome3-xorg

@worldofpeace worldofpeace requested review from jtojnar and hedning Dec 22, 2019
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Dec 22, 2019

Note the wmclass of gnome-terminal is specifically Gnome-terminal for some reason on xorg.

@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Dec 22, 2019

In a followup I'd like to try testing gnome-inital-setup. Mostly closing it and yelp that gets spawned afterwards.

@worldofpeace worldofpeace merged commit a408bcb into NixOS:master Jan 8, 2020
14 checks passed
14 checks passed
tests.gnome3-xorg on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.gnome3-xorg on x86_64-linux Success
Details
@worldofpeace worldofpeace deleted the worldofpeace:port-gnome3-xorg-test branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.