Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.arviz: init at 0.5.1 #73988

Merged
merged 2 commits into from Dec 12, 2019
Merged

Conversation

@OmnipotentEntity
Copy link
Contributor

@OmnipotentEntity OmnipotentEntity commented Nov 23, 2019

Motivation for this change

Introduce the python package arviz, which is a module for helping visualize Bayesian distributions. Particularly useful in Bayesian Neural Network analysis.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@OmnipotentEntity OmnipotentEntity force-pushed the OmnipotentEntity:arviz-0.5.1 branch from 54c5188 to f9a117b Nov 23, 2019
@OmnipotentEntity OmnipotentEntity requested a review from jonringer Nov 23, 2019
@risicle
Copy link
Contributor

@risicle risicle commented Nov 24, 2019

nix-review happy on macos 10.13

Copy link
Contributor

@jonringer jonringer left a comment

commit message should be:

python3Packages.arviz: init at 0.5.1

arviz alone would mean you are putting a top level attribute in all-packages.nix

@OmnipotentEntity OmnipotentEntity force-pushed the OmnipotentEntity:arviz-0.5.1 branch from d764d8d to 97f7f0a Nov 25, 2019
@OmnipotentEntity OmnipotentEntity changed the title arviz: init at 0.5.1 python3Packages.arviz: init at 0.5.1 Nov 26, 2019
@OmnipotentEntity
Copy link
Contributor Author

@OmnipotentEntity OmnipotentEntity commented Nov 26, 2019

commit message should be:

python3Packages.arviz: init at 0.5.1

arviz alone would mean you are putting a top level attribute in all-packages.nix

This should be fixed. I was able to fix the first remotely from my phone earlier today, but I didn't have access to Github to update the title.

@veprbl
Copy link
Member

@veprbl veprbl commented Nov 26, 2019

nix-review happy on macos 10.13

@risicle I'm much surprised. I was able to build this only after downgrading tensorflow-estimator and tensorflow-tensorboard to 0.14.0 to make tensorflow-bin build (#73703). And then test_data_tfp.py would completely fail all four of its tests.

@veprbl veprbl dismissed jonringer’s stale review Nov 26, 2019

Addressed

@OmnipotentEntity
Copy link
Contributor Author

@OmnipotentEntity OmnipotentEntity commented Nov 27, 2019

@veprbl Can you give output? I have a MacOSX machine I can test on. But the issue might be (and commonly is based on the other tests) other packages in the ecosystem being just plain broken on NixOS. I can disable that test if we cannot come to a satisfactory method of making it work.

However, it should be noted that when @risicle left that review I had tests disabled. It was only at the prompting of @jonringer that I added them back in.

@OmnipotentEntity OmnipotentEntity force-pushed the OmnipotentEntity:arviz-0.5.1 branch from 97f7f0a to ec1e2ac Nov 27, 2019
@veprbl
veprbl approved these changes Dec 11, 2019
Copy link
Member

@veprbl veprbl left a comment

Builds and works on darwin

@veprbl
Copy link
Member

@veprbl veprbl commented Dec 11, 2019

@GrahamcOfBorg build python37Packages.arviz

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 12, 2019

@GrahamcOfBorg build python37Packages.arviz

Copy link
Contributor

@jonringer jonringer left a comment

I would still like to see this squashed, otherwise LGTM

@veprbl veprbl merged commit aa3fcec into NixOS:master Dec 12, 2019
15 of 16 checks passed
15 of 16 checks passed
python37Packages.arviz on x86_64-darwin
Details
python37Packages.arviz on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python37Packages.arviz on x86_64-linux Success
Details
@OmnipotentEntity OmnipotentEntity deleted the OmnipotentEntity:arviz-0.5.1 branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.