Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.consul: init #74006

Merged
merged 2 commits into from Dec 6, 2019
Merged

nixosTests.consul: init #74006

merged 2 commits into from Dec 6, 2019

Conversation

@nh2
Copy link
Contributor

@nh2 nh2 commented Nov 24, 2019

Motivation for this change

Add a NixOS test for consul

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

FYI consul maintainers: @pradeepchhetri @vdemeester @nh2

CC @flokli and #72828

@nh2 nh2 requested a review from flokli Nov 24, 2019
@nh2 nh2 self-assigned this Nov 24, 2019
@ofborg ofborg bot added the 6.topic: nixos label Nov 24, 2019
@nh2
Copy link
Contributor Author

@nh2 nh2 commented Nov 24, 2019

@GrahamcOfBorg test consul

Copy link
Member

@worldofpeace worldofpeace left a comment

Please call your test in all-tests.nix.

@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 24, 2019

@GrahamcOfBorg test consul

@nh2
Copy link
Contributor Author

@nh2 nh2 commented Nov 24, 2019

Please call your test in all-tests.nix.

Looks like @Ma27 did it for me, thanks!

@nh2 nh2 requested a review from worldofpeace Nov 24, 2019
@worldofpeace worldofpeace dismissed their stale review Nov 24, 2019

Didn't see that failure

@flokli
Copy link
Contributor

@flokli flokli commented Nov 25, 2019

This didn't fail on my machine.

@GrahamcOfBorg test consul

@nh2
Copy link
Contributor Author

@nh2 nh2 commented Nov 27, 2019

Can I see the previous ofborg failure somehow? If there's a race I'd like to fix it.

@flokli
Copy link
Contributor

@flokli flokli commented Nov 28, 2019

@nh2
Copy link
Contributor Author

@nh2 nh2 commented Nov 28, 2019

@flokli Thanks, I found it: https://logs.nix.ci/?attempt_id=f102aeb5-eac3-453c-a49f-55378c84cd27&key=nixos%2Fnixpkgs.74006

Is the URL scheme documented somewhere I could bookmark?

@flokli
Copy link
Contributor

@flokli flokli commented Nov 28, 2019

I assume attempt_id is a UUID, and key owner/repo.prnumber, but I don't think it's more documented than that: https://github.com/NixOS/ofborg/blob/da348bdacce16cdd84f15b46e0b57deb1731a3c0/ofborg/src/tasks/githubcommentposter.rs#L179

@nh2 nh2 force-pushed the nh2:nixos-tests-consul branch from 4872b17 to 8360a62 Dec 6, 2019
@nh2
Copy link
Contributor Author

@nh2 nh2 commented Dec 6, 2019

I've pushed a fix for the test failure, should be non-racy now.

@GrahamcOfBorg test consul

@flokli
Copy link
Contributor

@flokli flokli commented Dec 6, 2019

Nice, thanks!

@flokli flokli merged commit 04071c6 into NixOS:master Dec 6, 2019
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.consul on aarch64-linux Success
Details
tests.consul on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.