Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regroup all themes under data/themes #74060

Merged
merged 5 commits into from Nov 25, 2019
Merged

Regroup all themes under data/themes #74060

merged 5 commits into from Nov 25, 2019

Conversation

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 24, 2019

Motivation for this change

Top-level misc folder is really not a good place to put things away so :
+ move remaining mislocated themes under data/themes
+ updated 3 KDE themes
+ locate GTK theming libraries ("engines") under development/libraries

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @romildo @gnidorah

+ move under data/themes
@romildo
Copy link
Contributor

romildo commented Nov 24, 2019

I think that the GTK theming libraries (engines) should not be at pkgs/desktops. In my understanding this directory is for desktop environments, and not for single libraries.

Maybe they should go to pkgs/development/libraries, like the qvantum package. But I am not sure.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 24, 2019

My reasoning was these engines are used for the theming of GTK-based desktop envs.
But I initially thought about dev/libraries too :) because well... it is libs. :)
I'll change that.

@c0bw3b c0bw3b force-pushed the c0bw3b:themes/kde branch from 10c320c to 8e1bef4 Nov 24, 2019
@romildo romildo self-requested a review Nov 25, 2019
@worldofpeace worldofpeace merged commit 5fcca4b into NixOS:master Nov 25, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
adapta-kde-theme, arc-kde-theme, kde2-decoration on aarch64-linux Success
Details
adapta-kde-theme, arc-kde-theme, kde2-decoration on x86_64-darwin Success
Details
adapta-kde-theme, arc-kde-theme, kde2-decoration on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace
Copy link
Member

worldofpeace commented Nov 25, 2019

I think we need to update https://nixos.org/nixpkgs/manual/#sec-hierarchy to include themes.
If you follow its instructions currently, I think most people are assuming it'll go under some place in misc.

@c0bw3b c0bw3b deleted the c0bw3b:themes/kde branch Nov 25, 2019
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 25, 2019

Indeed, I'll try and prepare a PR for the manual

@c0bw3b c0bw3b mentioned this pull request Nov 27, 2019
2 of 10 tasks complete
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 28, 2019
Regroup all themes under data/themes

(cherry picked from commit 5fcca4b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.