Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests: fail on failing subtests #74089

Merged
merged 1 commit into from Nov 25, 2019
Merged

Conversation

@globin
Copy link
Member

globin commented Nov 25, 2019

Motivation for this change

This was the behaviour in the perl test driver too and a regression.

Also cleaned up unused imports

cc @flokli

This was the behaviour in the perl test driver too and a regression.

Also cleaned up unused imports
@globin globin requested a review from flokli Nov 25, 2019
@flokli
flokli approved these changes Nov 25, 2019
Copy link
Contributor

flokli left a comment

D'oh! Thanks :-)

@flokli flokli merged commit 085ead7 into NixOS:master Nov 25, 2019
@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented on ba03a1b Nov 25, 2019

Thanks a lot @globin, I did actually notice this and wasn't sure if it was a regression.
#73134 (comment)

This comment has been minimized.

Copy link
Contributor

tfc replied Nov 25, 2019

Hey there,

thank you for fixing this @globin.

This commit does look like it was pushed directly without a pull request. Is this impression correct?
If yes, then i must state (although this specific commit is fine) that i generally do not feel well with this PR-avoiding approach - because simply pushing to master circumvents code review.

This comment has been minimized.

Copy link
Member

worldofpeace replied Nov 25, 2019

@tfc It's here #74089.

@tfc
Copy link
Contributor

tfc commented Nov 25, 2019

@tfc It's here #74089.

Oh, my bad then! Thank you. Please put me on the reviewer's list in the future, too, as i have a lot of stakes in the python test driver since i wrote it and am interested to be on track what's changed. That would be nice.

@worldofpeace
Copy link
Member

worldofpeace commented Nov 25, 2019

@tfc It's here #74089.

Oh, my bad then! Thank you. Please put me on the reviewer's list in the future, too, as i have a lot of stakes in the python test driver since i wrote it and am interested to be on track what's changed. That would be nice.

Absolutely 👍 You might even consider adding yourself to CODEOWNERS for the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.