Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.m3u8: init at 0.5.2 #74110

Merged
merged 1 commit into from Jan 9, 2020
Merged

pythonPackages.m3u8: init at 0.5.2 #74110

merged 1 commit into from Jan 9, 2020

Conversation

@Scriptkiddi
Copy link
Contributor

Scriptkiddi commented Nov 25, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

jonringer left a comment

There's no tests located in the pypi package, do you mind checking out the code from github:

running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
Finished executing setuptoolsCheckPhase
/nix/store/93asqnc8d8q1bpw32dfc198xfn9wxx2s-python3.7-m3u8-0.5.2
@Scriptkiddi

This comment has been minimized.

Copy link
Contributor Author

Scriptkiddi commented Nov 26, 2019

the python test are done running runtests and it sets up a http server, is that what we want in a python test?

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 26, 2019

There's some tests such as https://github.com/globocom/m3u8/blob/master/tests/test_parser.py which seem to be unit tests.

It doesn't have to be full integration tests, but tests are useful to ensure that the application still works in most use cases.

@Scriptkiddi Scriptkiddi force-pushed the Scriptkiddi:py3_m3u8 branch from b86ce66 to d75076a Dec 18, 2019
@Scriptkiddi

This comment has been minimized.

Copy link
Contributor Author

Scriptkiddi commented Dec 18, 2019

@jonringer added the tests

${python.interpreter} -m pytest tests/test_parser.py
${python.interpreter} -m pytest tests/test_model.py
${python.interpreter} -m pytest tests/test_variant_m3u8.py
Comment on lines 17 to 19

This comment has been minimized.

Copy link
@jonringer

jonringer Dec 18, 2019

Contributor

this can be simply:

  pytest tests/test_{parser,model,variant_m3u8}.py

This comment has been minimized.

Copy link
@Scriptkiddi

Scriptkiddi Dec 19, 2019

Author Contributor

done

This comment has been minimized.

Copy link
@jonringer

jonringer Dec 19, 2019

Contributor

pytest can accept multiple paths, and {...} is bash expansion

@Scriptkiddi Scriptkiddi force-pushed the Scriptkiddi:py3_m3u8 branch from d75076a to 459cff6 Dec 19, 2019
Copy link
Contributor

jonringer left a comment

pytest tests/test_{parser,model,variant_m3u8}.py

runs the same tests as

pytest tests/test_parser.py
pytest tests/test_model.py
 pytest tests/test_variant_m3u8.py

but it collects them all into a single run (which is easier to digest)

pkgs/development/python-modules/m3u8/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/m3u8/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/m3u8/default.nix Outdated Show resolved Hide resolved
@Scriptkiddi Scriptkiddi force-pushed the Scriptkiddi:py3_m3u8 branch from 6300208 to da2a954 Dec 21, 2019
Copy link
Contributor

jonringer left a comment

diff LGTM
commits LGTM
has tests 👍

[5 built, 54 copied (21.9 MiB), 4.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74110
3 package were built:
python27Packages.m3u8 python37Packages.m3u8 python38Packages.m3u8
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 9, 2020

@GrahamcOfBorg build python27Packages.m3u8 python37Packages.m3u8 python38Packages.m3u8

@jonringer jonringer merged commit cef835d into NixOS:master Jan 9, 2020
15 of 16 checks passed
15 of 16 checks passed
python27Packages.m3u8, python37Packages.m3u8, python38Packages.m3u8 on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.m3u8, python37Packages.m3u8, python38Packages.m3u8 on aarch64-linux Success
Details
python27Packages.m3u8, python37Packages.m3u8, python38Packages.m3u8 on x86_64-darwin Success
Details
@Scriptkiddi Scriptkiddi deleted the Scriptkiddi:py3_m3u8 branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.