Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vegeta: init at 12.7.0 #74115

Closed
wants to merge 1 commit into from
Closed

vegeta: init at 12.7.0 #74115

wants to merge 1 commit into from

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 25, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

goPackagePath = "github.com/tsenart/vegeta";
modSha256 = "1wzx9588hjzxq65fxi1zz9xpsw33qq41hpl0j2f077g4m8yxahv5";
Comment on lines +7 to +8

This comment has been minimized.

@jonringer

jonringer Nov 28, 2019 Contributor

I most commonly see this come after src.

otherwise, diff LGTM

This comment has been minimized.

@jonringer

jonringer Nov 28, 2019 Contributor

also, i believe buildGoModule doesn't really make use of goPackagePath

@mmahut
Copy link
Member

mmahut commented Jan 31, 2020

Superseded by #78948

@mmahut mmahut closed this Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.