Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.riak: port to python #74124

Merged
merged 2 commits into from Jan 31, 2020
Merged

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 25, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

filalex77 added 2 commits Nov 25, 2019
@filalex77
Copy link
Contributor Author

filalex77 commented Nov 25, 2019

@GrahamcOfBorg test riak

@Mic92
Copy link
Contributor

Mic92 commented Nov 25, 2019

riak is not yet in all-tests.nix. However it could be added. Than also @GrahamcOfBorg test riak would work.

@Mic92
Copy link
Contributor

Mic92 commented Nov 25, 2019

Might be also worth to bump riak: https://github.com/basho/riak/releases/tag/riak-2.9.0p5
The current version is marked as insecure. So the test won't build.

@tfc
tfc approved these changes Dec 1, 2019
@worldofpeace worldofpeace added this to the 20.03 milestone Jan 31, 2020
@worldofpeace worldofpeace self-assigned this Jan 31, 2020
@worldofpeace
Copy link
Member

worldofpeace commented Jan 31, 2020

this makes me question things #33876 (comment). good to merge though, no point of adding to all-tests.nix because it can't even eval it

@worldofpeace worldofpeace merged commit 758b1b9 into NixOS:master Jan 31, 2020
14 checks passed
14 checks passed
tests.riak on aarch64-linux No attempt
Details
tests.riak on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace worldofpeace removed their assignment Jan 31, 2020
anna328p added a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.