Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runelite: 1.6.0 -> 2.0.0 #74136

Merged
merged 1 commit into from Jan 6, 2020
Merged

runelite: 1.6.0 -> 2.0.0 #74136

merged 1 commit into from Jan 6, 2020

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 25, 2019

Motivation for this change

2.0.2 (latest) doesn't provide a RuneLite.jar.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Kmeakin


This change is Reviewable

@filalex77
Copy link
Contributor Author

filalex77 commented Nov 25, 2019

@GrahamcOfBorg build runelite

@filalex77 filalex77 marked this pull request as ready for review Nov 25, 2019
pkgs/games/runelite/default.nix Outdated Show resolved Hide resolved
@filalex77 filalex77 force-pushed the filalex77:runelite-2.0.0 branch from f9df8d0 to 37281a9 Jan 6, 2020
@filalex77
Copy link
Contributor Author

filalex77 commented Jan 6, 2020

Thanks @marsam!

@filalex77 filalex77 requested a review from marsam Jan 6, 2020
Co-authored-by: Mario Rodas <marsam@users.noreply.github.com>
@marsam marsam force-pushed the filalex77:runelite-2.0.0 branch from 37281a9 to f930613 Jan 6, 2020
@marsam marsam merged commit b103b3f into NixOS:master Jan 6, 2020
@marsam
Copy link
Contributor

marsam commented Jan 6, 2020

Thank you @filalex77!

@filalex77 filalex77 deleted the filalex77:runelite-2.0.0 branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.