Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphite2: 1.3.6 -> 1.3.13 #74155

Merged
merged 1 commit into from Nov 29, 2019
Merged

Conversation

@nh2
Copy link
Contributor

nh2 commented Nov 25, 2019

Fixes various security bugs with CVEs since 2017.

Fixes #73645.

Note that for 1.3.6 ONLY, the file was called graphite-*.tgz
and not graphite2-*.tgz, that's why the URL changes as well.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

@nh2 nh2 requested a review from 7c6f434c Nov 25, 2019
@nh2 nh2 self-assigned this Nov 25, 2019
@nh2 nh2 mentioned this pull request Nov 25, 2019
0 of 7 tasks complete
@nh2
Copy link
Contributor Author

nh2 commented Nov 25, 2019

@ckauhaus
Copy link
Contributor

ckauhaus commented Nov 26, 2019

should go to staging due to the amount of rebuilds

Fixes various security bugs with CVEs since 2017.

Fixes #73645.

Note that for 1.3.6 *ONLY*, the file was called `graphite-*.tgz`
and not `graphite2-*.tgz`, that's why the URL changes as well.
@nh2 nh2 force-pushed the nh2:issue-73645-graphite2-1.3.13 branch from 34775f0 to de97cb7 Nov 26, 2019
@nh2 nh2 changed the base branch from master to staging Nov 26, 2019
@nh2
Copy link
Contributor Author

nh2 commented Nov 26, 2019

@nh2
Copy link
Contributor Author

nh2 commented Nov 26, 2019

should go to staging due to the amount of rebuilds

Done; I wasn't quite sure if I should put it on staging given that it's security

@7c6f434c
Copy link
Member

7c6f434c commented Nov 26, 2019

Hm, some of these seem to have been remotely abusable in Firefox?

@nh2
Copy link
Contributor Author

nh2 commented Nov 26, 2019

Hm, some of these seem to have been remotely abusable in Firefox?

@7c6f434c Yes that's how I understood it.

@7c6f434c
Copy link
Member

7c6f434c commented Nov 27, 2019

@ckauhaus Do we have any procedure for PRs against staging-merge for high-impact but very high-rebuild fixes?

@jonringer
Copy link
Contributor

jonringer commented Nov 27, 2019

staging to bring in large rebuilds, then staging-next is used for stabilization of the affected packages.

@jonringer jonringer added this to WIP in Staging via automation Nov 27, 2019
@alyssais alyssais removed their request for review Nov 28, 2019
@ckauhaus ckauhaus merged commit 4da13bc into NixOS:staging Nov 29, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
graphite2 on aarch64-linux Success
Details
graphite2 on x86_64-linux Success
Details
Staging automation moved this from WIP to Done Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.