Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeowners: Add tfc as test-driver owner #74169

merged 1 commit into from Nov 25, 2019


Copy link

tfc commented Nov 25, 2019

Motivation for this change

I wrote the initial version of the python test driver and would like to stay on track what's happening with it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @flokli @worldofpeace @Lassulus

@tfc tfc requested a review from edolstra as a code owner Nov 25, 2019
Copy link

worldofpeace left a comment

Sounds good. I anyone else would like to they should submit a PR.

@worldofpeace worldofpeace merged commit d9ab267 into NixOS:master Nov 25, 2019
@tfc tfc deleted the tfc:codeowners-test-driver branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.