Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alacritty: 0.3.3 -> 0.4.0 #74187

Merged
merged 2 commits into from Nov 26, 2019
Merged

alacritty: 0.3.3 -> 0.4.0 #74187

merged 2 commits into from Nov 26, 2019

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 25, 2019

Also:

  • remove postPatch (config is not generated anymore; i.e. there's no mouse.rs or xdg-open mentions anywhere
Motivation for this change

https://github.com/jwilm/alacritty/releases/tag/v0.4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92


This change is Reviewable

filalex77 added 2 commits Nov 25, 2019
Also:
- remove postPatch (config is not generated anymore;
  i.e. there's no `mouse.rs` or `xdg-open` mentions anywhere
@filalex77
Copy link
Contributor Author

filalex77 commented Nov 25, 2019

@GrahamcOfBorg build alacritty

@filalex77
Copy link
Contributor Author

filalex77 commented Nov 26, 2019

Would be great if somebody ran a build on Darwin (and merged, probably) ;)

@Ma27 Ma27 merged commit ad80b0a into NixOS:master Nov 26, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
alacritty on aarch64-linux Success
Details
alacritty on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Mic92
Copy link
Contributor

Mic92 commented Nov 27, 2019

@GrahamcOfBorg build alacritty

@filalex77
Copy link
Contributor Author

filalex77 commented Nov 27, 2019

@Mic92 Probably doesn't work because the PR is merged. Oh well, we'll just have to wait and see :(

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented on c8ca52c Feb 20, 2020

Unfortunately this breaks clicking on links in Alacritty, and was a bit surprised by you not finding the file:

[grahamc@Petunia:~/projects/github.com/jwilm/alacritty]$ git checkout v0.4.0
HEAD is now at b115b90 Bump version to 0.4.0

[grahamc@Petunia:~/projects/github.com/jwilm/alacritty]$ rg xdg-
alacritty.yml
400:    #   - (Linux) xdg-open
403:    #  program: xdg-open

alacritty/src/config/mouse.rs
76:            launcher: Some(CommandWrapper::Just(String::from("xdg-open"))),
[grahamc@Petunia:~/projects/github.com/jwilm/alacritty]$ git checkout v0.4.1
Previous HEAD position was b115b90 Bump version to 0.4.0
HEAD is now at 4d9253b Bump version to 0.4.1

[grahamc@Petunia:~/projects/github.com/jwilm/alacritty]$ rg xdg-
alacritty.yml
399:    #   - (Linux/BSD) xdg-open
402:    #  program: xdg-open

alacritty/src/config/mouse.rs
76:            launcher: Some(CommandWrapper::Just(String::from("xdg-open"))),

but then i saw that the path changed from alacritty_terminal to alacritty -- no worries.

at any rate, I've reverted this portion of the commit in a905deb and 236a83a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.