Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onefetch: init at 2.1.0 #74191

Merged
merged 1 commit into from Nov 27, 2019
Merged

onefetch: init at 2.1.0 #74191

merged 1 commit into from Nov 27, 2019

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 25, 2019

Motivation for this change

Close #72254

@Kloenk - feel free to add yourself as a maintainer, if you'd like.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut @jonringer


This change is Reviewable

@filalex77
Copy link
Contributor Author

filalex77 commented Nov 25, 2019

@GrahamcOfBorg build onefetch

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
executable shows usage

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74191
1 package were built:
onefetch
@jonringer
Copy link
Contributor

jonringer commented Nov 25, 2019

@GrahamcOfBorg build onefetch

@filalex77 filalex77 force-pushed the filalex77:onefetch-2.1.0 branch from 17f9784 to 22788c6 Nov 26, 2019
@filalex77
Copy link
Contributor Author

filalex77 commented Nov 26, 2019

@jonringer Build on darwin should be fixed now, please re-run the darwin build.

@GrahamcOfBorg build onefetch

@filalex77 filalex77 requested a review from jonringer Nov 26, 2019
@Kloenk Kloenk mentioned this pull request Nov 26, 2019
4 of 10 tasks complete
@jonringer
Copy link
Contributor

jonringer commented Nov 26, 2019

@GrahamcOfBorg build onefetch

Co-authored-by: Kloenk <Kloenk@users.noreply.github.com>
@filalex77 filalex77 force-pushed the filalex77:onefetch-2.1.0 branch from 22788c6 to d06859a Nov 26, 2019
@filalex77
Copy link
Contributor Author

filalex77 commented Nov 26, 2019

@jonringer I think I added all the needed frameworks and libraries for Darwin now. Could you please run the build again? Sorry to ping you so much; the PR adding me to trusted users for ofBorg is not merged yet.

@jonringer
Copy link
Contributor

jonringer commented Nov 27, 2019

@GrahamcOfBorg build onefetch

@filalex77
Copy link
Contributor Author

filalex77 commented Nov 27, 2019

@jonringer I think it's fine now - the PR can be merged. Thanks a lot for your help!

filalex77 added a commit to filalex77/onefetch that referenced this pull request Nov 27, 2019
After NixOS/nixpkgs#74191 gets merged, this fine is no longer necessary.

cc @Kloenk
@jonringer
Copy link
Contributor

jonringer commented Nov 27, 2019

previous review still stand, LGTM

@jonringer jonringer merged commit fb00dac into NixOS:master Nov 27, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
onefetch on aarch64-linux Success
Details
onefetch on x86_64-darwin Success
Details
onefetch on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.