Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pony: init at 0.7.11 #74193

Merged
merged 1 commit into from Nov 25, 2019
Merged

Conversation

@d-goldin
Copy link
Contributor

d-goldin commented Nov 25, 2019

Motivation for this change

pony is an ORM library.

The main motivation for adding this package is to allow migrating trible
to a newer version that supports python3.

Also adding myself to maintainers to not leave this one without, even
though I dont use it myself much, if anybody else feels like it fits their
interests, feel free to add yourselves.

Related: #73927

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@d-goldin d-goldin requested review from FRidh and jonringer as code owners Nov 25, 2019
pony is an ORM library.

The main motivation for adding this package is to allow migrating
tribler to a newer version that supports python3.

Also adding myself to maintainers to not leave this one without, even
though I dont use it myself much, if anybody else feels like it fits their
interests, feel free to add yourselves.
@d-goldin d-goldin force-pushed the d-goldin:python_init_pony branch from 0a85fb0 to c68bc50 Nov 25, 2019
@d-goldin
Copy link
Contributor Author

d-goldin commented Nov 25, 2019

@GrahamcOfBorg build pythonPackages.pony

@d-goldin d-goldin mentioned this pull request Nov 25, 2019
4 of 10 tasks complete
@FRidh
FRidh approved these changes Nov 25, 2019
@ofborg ofborg bot added the 6.topic: python label Nov 25, 2019
@flokli
Copy link
Contributor

flokli commented Nov 25, 2019

Could do a from pony.orm.examples.estore import * with that pony, so I assume it's still working :-)

@flokli flokli merged commit 332fd29 into NixOS:master Nov 25, 2019
3 of 4 checks passed
3 of 4 checks passed
grahamcofborg-eval Checking new out paths
Details
pythonPackages.pony on aarch64-linux Success
Details
pythonPackages.pony on x86_64-darwin Success
Details
pythonPackages.pony on x86_64-linux Success
Details
@d-goldin
Copy link
Contributor Author

d-goldin commented Nov 25, 2019

@flokli: I did sth like that but also ran tribler against it and it seemed fine enough. If you feel like trying out, there is a draft PR: #74195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.