Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.containers*: port to python #74196

Merged
merged 4 commits into from Nov 25, 2019

Conversation

@tfc
Copy link
Contributor

tfc commented Nov 25, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @flokli @Lassulus

@tfc
Copy link
Contributor Author

tfc commented Nov 25, 2019

@GrahamcOfBorg test containers-ephemeral containers-hosts containers-reloadable containers-tmpfs

Copy link
Contributor

flokli left a comment

one minor nitpick.

nixos/tests/containers-reloadable.nix Outdated Show resolved Hide resolved
@tfc tfc force-pushed the tfc:nixos-test-containers-python-port branch from aa998a2 to ab374b3 Nov 25, 2019
@flokli flokli changed the title Nixos test containers python port nixosTests.containers*: port to python Nov 25, 2019
@flokli
Copy link
Contributor

flokli commented Nov 25, 2019

@GrahamcOfBorg test containers-ephemeral containers-hosts containers-reloadable containers-tmpfs

@flokli flokli merged commit 19ba87f into NixOS:master Nov 25, 2019
1 of 2 checks passed
1 of 2 checks passed
tests.containers-ephemeral, tests.containers-hosts, tests.containers-reloadable, tests.containers-tmpfs on aarch64-linux
Details
tests.containers-ephemeral, tests.containers-hosts, tests.containers-reloadable, tests.containers-tmpfs on x86_64-linux Success
Details
@tfc tfc deleted the tfc:nixos-test-containers-python-port branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.