Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noise-repellent: init at unstable-29-12-2018 #74204

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@magnetophon
Copy link
Member

magnetophon commented Nov 25, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @


stdenv.mkDerivation rec {
pname = "noise-repellent";
version = "unstable-29-12-2018";

This comment has been minimized.

@jonringer

jonringer Nov 26, 2019 Contributor

the date format is YYYY-MM-DD https://nixos.org/nixpkgs/manual/#sec-package-naming

Suggested change
version = "unstable-29-12-2018";
version = "unstable-29-12-2018";

This comment has been minimized.

@magnetophon

magnetophon Nov 26, 2019 Author Member

Thanks for the feedback. Done.

@magnetophon magnetophon force-pushed the magnetophon:noise-repellent branch from 4daf240 to 6e64cc5 Nov 26, 2019
Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
no idea how to test

[3 built, 2 copied (1.3 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74204
1 package were built:
noise-repellent
@jonringer
Copy link
Contributor

jonringer commented Nov 26, 2019

@GrahamcOfBorg build noise-repellent

@jonringer
Copy link
Contributor

jonringer commented Nov 26, 2019

looks like arch doesn't like some of the compiler flags (architecture extensions), if arch is not a supported architecture, then I would change meta.platforms to reflect just the x86_64 variants

/nix/store/nalgbdpjmhizap3sp1q3lqinisifldl9-gcc-wrapper-8.3.0/bin/cc -Inrepel@sha -I. -I.. -I/nix/store/mwjc8kdg97nbl07bwsr96arkqmiz2v1w-fftw-single-3.3.8-dev/include -I/nix/store/6n1ib7m8axh6k75n6v9nkhbxp7s89ym6-lv2-1.16.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC -msse -msse2 -mfpmath=sse -ffast-math -fomit-frame-pointer -fno-finite-math-only -MD -MQ 'nrepel@sha/src_nrepel.c.o' -MF 'nrepel@sha/src_nrepel.c.o.d' -o 'nrepel@sha/src_nrepel.c.o' -c ../src/nrepel.c
gcc: error: unrecognized command line option '-msse'; did you mean '-fdse'?
gcc: error: unrecognized command line option '-msse2'
gcc: error: unrecognized command line option '-mfpmath=sse'
ninja: build stopped: subcommand failed.
builder for '/nix/store/7zy3w7g3mpk39zyr1ag7w8iwg364clg2-noise-repellent-unstable-2018-12-29.drv' failed with exit code 1
error: build of '/nix/store/7zy3w7g3mpk39zyr1ag7w8iwg364clg2-noise-repellent-unstable-2018-12-29.drv' failed
@magnetophon magnetophon force-pushed the magnetophon:noise-repellent branch from 6e64cc5 to 6c70f85 Nov 26, 2019
@magnetophon
Copy link
Member Author

magnetophon commented Nov 26, 2019

OK, platforms are updated.

@jonringer jonringer merged commit fd2f245 into NixOS:master Nov 26, 2019
15 checks passed
15 checks passed
noise-repellent on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
noise-repellent on x86_64-linux Success
Details
@magnetophon magnetophon deleted the magnetophon:noise-repellent branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.