Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facedetect: switch to opencv4 #74212

wants to merge 1 commit into from


Copy link

risicle commented Nov 25, 2019

Motivation for this change

opencv2 is essentially EOL and has security concerns

No formal tests, so tested this on some images myself.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @rycee

opencv2 is essentially EOL and has security concerns
@ofborg ofborg bot requested a review from rycee Nov 26, 2019
@rycee rycee self-assigned this Nov 26, 2019
Copy link

rycee commented Nov 26, 2019

Yep, seems to work just fine! Rebased to master in 8361442. Thanks for the fix 👍

@rycee rycee closed this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.