Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdf4store: remove pkg and service modules #74214

Merged
merged 1 commit into from Dec 8, 2019
Merged

Conversation

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 25, 2019

Motivation for this change

As of today the 4store pkg (rdf4store attribute) :

  • has been marked as broken since April 2018 #39312
  • has no pending issue in our tracker asking to revive it
  • has lost its former website (see 4store/4store#137) although there is a GitHub repo
  • there has been talks of a new release upstream back in 2017 (see 4store/4store#117) but it's pretty much inactive since
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

@c0bw3b c0bw3b force-pushed the c0bw3b:rem/4store branch from 3b67114 to 0b5456f Dec 8, 2019
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Dec 8, 2019

@7c6f434c > are you ok with this removal?

@7c6f434c
Copy link
Member

7c6f434c commented Dec 8, 2019

Yes, Apache Jena is enough for whenever I need RDF. Somehow missed the original mention, sorry.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Dec 8, 2019

No problem, thanks

@c0bw3b c0bw3b merged commit f640cf4 into NixOS:master Dec 8, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Picking up garbage automation moved this from In progress to Done Dec 8, 2019
@c0bw3b c0bw3b deleted the c0bw3b:rem/4store branch Dec 8, 2019
c0bw3b added a commit that referenced this pull request Dec 21, 2019
Addition to #74214
I forgot to add aliases for package and modules after removal
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 19, 2020
Addition to NixOS#74214
I forgot to add aliases for package and modules after removal

(cherry picked from commit b1b55ba)
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Mar 11, 2020
(NixOS#74214)

(cherry picked from commit f640cf4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.