Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel.tests: update the protobuf test to the latest protobuf version #74216

Open
wants to merge 1 commit into
base: master
from

Conversation

@kalbasit
Copy link
Member

kalbasit commented Nov 25, 2019

Motivation for this change

Update the Bazel protobuf test to use the latest stable protobuf version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Profpatsch @guibou @mboes

@kalbasit kalbasit requested a review from Profpatsch as a code owner Nov 25, 2019
@kalbasit kalbasit force-pushed the kalbasit:nixpkgs_update-bazel-tests-protobuf branch from 76c2385 to 0238f5c Nov 25, 2019
@kalbasit
Copy link
Member Author

kalbasit commented Nov 25, 2019

@GrahamcOfBorg build bazel.tests

@Profpatsch
Copy link
Member

Profpatsch commented Nov 26, 2019

Can’t you use the same packages we use in the bazel update script for that? The protobuf test is in the bazel repo, no?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.
@stale stale bot added the 2.status: stale label Jun 1, 2020
@Profpatsch
Copy link
Member

Profpatsch commented Jun 9, 2020

So the bazel WORKSPACE file already defines protobuf and dependencies: https://github.com/NixOS/nixpkgs//blob/master/pkgs/development/tools/build-managers/bazel/bazel_3/src-deps.json#L146-L168

We should really run the test against that, otherwise it doesn’t make much sense I think.

@stale stale bot removed the 2.status: stale label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.