Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nixos test containers python port #74218

Merged
merged 3 commits into from Nov 27, 2019
Merged

Conversation

@tfc
Copy link
Contributor

tfc commented Nov 25, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli @worldofpeace @Lassulus

@tfc
Copy link
Contributor Author

tfc commented Nov 25, 2019

@GrahamcOfBorg test containers-bridge containers-ipv4 containers-ipv6

Copy link
Contributor

flokli left a comment

As all of these are very similar, what do you think about joining the network-related ones into a single testScript, and testing each variant in a subtest?

chomp $ip;
$machine->succeed("ping -n -c1 $ip");
$machine->succeed("curl --fail http://$ip/ > /dev/null");
with subtest("wait 2s for container to start and network to be up"):

This comment has been minimized.

@flokli

flokli Nov 26, 2019 Contributor

I think we shouldn't overdo with grouping things into subtests. This should really be just a comment. ;-)

@tfc tfc force-pushed the tfc:nixos-test-containers-python-port branch 2 times, most recently from e528601 to 1479e03 Nov 26, 2019
@tfc
Copy link
Contributor Author

tfc commented Nov 26, 2019

@GrahamcOfBorg test containers-bridge containers-ipv containers-imperative

@tfc tfc force-pushed the tfc:nixos-test-containers-python-port branch from 1479e03 to f58088c Nov 26, 2019
@tfc
Copy link
Contributor Author

tfc commented Nov 26, 2019

@GrahamcOfBorg test containers-bridge containers-ip containers-imperative

@tfc tfc force-pushed the tfc:nixos-test-containers-python-port branch from f58088c to b1e9e7c Nov 26, 2019
@tfc
Copy link
Contributor Author

tfc commented Nov 26, 2019

@GrahamcOfBorg test containers-bridge containers-ip containers-imperative

@tfc tfc force-pushed the tfc:nixos-test-containers-python-port branch from b1e9e7c to 9de0a8a Nov 27, 2019
@tfc
Copy link
Contributor Author

tfc commented Nov 27, 2019

@GrahamcOfBorg test containers-bridge containers-ip containers-imperative

@globin globin merged commit 39022bc into NixOS:master Nov 27, 2019
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.containers-bridge, tests.containers-imperative, tests.containers-ip on aarch64-linux Success
Details
tests.containers-bridge, tests.containers-imperative, tests.containers-ip on x86_64-linux Success
Details
@tfc tfc deleted the tfc:nixos-test-containers-python-port branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.