Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequoia: 0.11.0 -> 0.13.0 #74290

Closed
wants to merge 1 commit into from
Closed

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Nov 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @minijackson

@doronbehar doronbehar force-pushed the doronbehar:update-sequoia branch from f72517d to ec9a353 Dec 26, 2019
@doronbehar doronbehar changed the title sequoia: 0.11.0 -> 0.12.0 sequoia: 0.11.0 -> 0.13.0 Dec 26, 2019
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Dec 26, 2019

@worldofpeace Could you take a look please? BTW I think they've done something with the tests (possibly thanks to our complains) so it might worth checking Darwin again. cc who checked this last upgrade in #73104, also cc @jonringer who noticed the build failure in hydra.

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 26, 2019

@GrahamcOfBorg build sequoia

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 27, 2019

IIRC the build would fail for another reason on darwin, so it wasn't test related.

@doronbehar doronbehar force-pushed the doronbehar:update-sequoia branch from ec9a353 to 047bb86 Dec 27, 2019
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Dec 27, 2019

I've commented the broken flag, could you please test now?

@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Jan 8, 2020

I wish this wouldn't have taken so long...

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 8, 2020

@GrahamcOfBorg build sequoia

@doronbehar doronbehar mentioned this pull request Feb 4, 2020
2 of 10 tasks complete
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Feb 5, 2020

Closed in #79226.

@doronbehar doronbehar closed this Feb 5, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 11, 2020

Sorry about this @doronbehar, January was a pretty difficult month with release management and all, so I forgot about this. Only did I remember it when I saw #79226, so I merged that quickly because it was ready.

@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Feb 12, 2020

Don't mind it @worldofpeace . If you are interested, 0.14.0 came out right after #79226 was merged so please have a look at #79758 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.