Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lots of pygtk using software #74295

Merged
merged 21 commits into from Dec 11, 2019
Merged

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Nov 26, 2019

Motivation for this change

A lot of these programs that use pygtk, which is using python2, are just completely abandoned and nixpkgs doesn't need to hold onto them.

Additionally, there's certain packages that in their latest released version don't use deprecated bindings. I will try to handle some of these updates.


This is a draft. I'm not finished so review isn't needed just yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace added this to To do in Picking up garbage via automation Nov 26, 2019
@worldofpeace worldofpeace moved this from To do to In progress in Picking up garbage Nov 26, 2019
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Nov 26, 2019

@romildo connman-notify is marked as broken here. In later versions it has been ported to python3.
Are you still interested in maintaining this?

@romildo
Copy link
Contributor

@romildo romildo commented Nov 27, 2019

I am still using phwmon to monitor cpu, memory, etc. with light window managers like openbox, fluxbox and awesome. It is working well for me.

@romildo
Copy link
Contributor

@romildo romildo commented Nov 27, 2019

@romildo connman-notify is marked as broken here. In later versions it has been ported to python3.
Are you still interested in maintaining this?

Yes, I am. I will take a look at the python3 based version.

I am waiting for a release of connman with good integration with iwd to make connman my network manager of choice.

@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Nov 27, 2019

I am still using phwmon to monitor cpu, memory, etc. with light window managers like openbox, fluxbox and awesome. It is working well for me.

Thanks. That was one of the entries I had a strong feeling was going to become a dropped commit 👍

@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Nov 27, 2019

Though it's actually a pretty small script, it could be easily ported to python3 and gobject bindings

@veprbl
Copy link
Member

@veprbl veprbl commented Nov 27, 2019

@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Nov 27, 2019

@veprbl As stated, this PR isn't ready for review because I'm not certain all removed packages are appropriate. So I don't really want to attract to much attention like people's packages are in danger of removal.

@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Nov 27, 2019

@romildo
Copy link
Contributor

@romildo romildo commented Nov 27, 2019

@romildo connman-notify is marked as broken here. In later versions it has been ported to python3.
Are you still interested in maintaining this?

Yes, I am. I will take a look at the python3 based version.

I am waiting for a release of connman with good integration with iwd to make connman my network manager of choice.

Updated connman-notify: #74321

@romildo
Copy link
Contributor

@romildo romildo commented Nov 27, 2019

Though it's actually a pretty small script, it could be easily ported to python3 and gobject bindings

* https://gitlab.com/o9000/phwmon/blob/master/phwmon.py

Issue entry in upstream: https://gitlab.com/o9000/phwmon/issues/4

@veprbl
Copy link
Member

@veprbl veprbl commented Nov 27, 2019

@worldofpeace Sorry, I didn't mean to cause any trouble here.

@worldofpeace worldofpeace force-pushed the worldofpeace:remove-pygtk-users branch 2 times, most recently from 88d7ea5 to baae3a4 Nov 27, 2019
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Nov 27, 2019

Going to leave some of my research on the remaining packages here:

  • ocropus has a fork kraken that supports python3
    there's also a wip PR:
    ocropus/ocropy#319

pmenu has no activity of a python3 port
https://gitlab.com/o9000/pmenu cc @romildo

xdgmenumaker supports python3
https://github.com/gapan/xdgmenumaker#about cc @romildo

libappindicator
Remove python completely
https://src.fedoraproject.org/rpms/libappindicator/blob/master/f/nopython.patch

mpdris2 has python3 support
cc @pjones

@ofborg ofborg bot added the 6.topic: nixos label Nov 27, 2019
@worldofpeace worldofpeace force-pushed the worldofpeace:remove-pygtk-users branch from 0933677 to e07c787 Dec 5, 2019
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Dec 5, 2019

uzbl and pywebkitgtk got moved into #75040.

@worldofpeace worldofpeace force-pushed the worldofpeace:remove-pygtk-users branch from e07c787 to 8979c7a Dec 5, 2019
worldofpeace added 21 commits Dec 11, 2019
This one was already marked as broken.
This package actually uses the old abandoned code base.
However the code base has been revieved by new maintainers
* https://github.com/projecthamster/
if there is a request for it could be re-added to nixpkgs.
People have only been using this for the spell-entry widget, i.e even
hexchat just has the code vendored and are maintaining it themselves.

There is a continuation that could be packaged if anyone needs it
* https://github.com/TingPing/libsexy3
but currently no package within nixpkgs has a use for this.
This doesn't even need this.
Uses python3, no more pygtk.
The qt version is using qt4 pyqt and the gtk version gtk2 pygtk.
Not seeing any activity at all at https://sourceforge.net/p/recordmydesktop/bugs/
bleachbit is aiming to support python3 around January of 2020 [0].

[0]: bleachbit/bleachbit#163
Got the ok from romildo to remove this as jgmenu [0]
is more complete, and has a module based off pmenu.

[0]: https://github.com/johanmalm/jgmenu
@worldofpeace worldofpeace force-pushed the worldofpeace:remove-pygtk-users branch from 8979c7a to 419dacd Dec 11, 2019
@worldofpeace worldofpeace mentioned this pull request Dec 11, 2019
1 of 24 tasks complete
@worldofpeace worldofpeace merged commit e159f1d into NixOS:master Dec 11, 2019
14 of 16 checks passed
14 of 16 checks passed
bleachbit, hexchat, tryton on aarch64-linux
Details
bleachbit, hexchat, tryton on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
bleachbit, hexchat, tryton on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Picking up garbage automation moved this from In progress to Done Dec 11, 2019
@worldofpeace worldofpeace deleted the worldofpeace:remove-pygtk-users branch Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.