Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmic, gmic-qt: switch to opencv3 #74301

Merged
merged 2 commits into from Dec 6, 2019
Merged

gmic, gmic-qt: switch to opencv3 #74301

merged 2 commits into from Dec 6, 2019

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Nov 27, 2019

Motivation for this change

opencv2 is essentially EOL and has security concerns

opencv is reportedly only used for webcam input in gmic, and I've successfully managed to get webcam pictures with this built against opencv3.

Reverse dependencies gimpPlugins.gmic and gimp-with-plugins seem to be already broken on master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

risicle added 2 commits Nov 27, 2019
opencv2 is essentially EOL and has security concerns
opencv2 is essentially EOL and has security concerns
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 4, 2019

Could you open an upstream issue/PR about switching to OpenCV 4?

@risicle
Copy link
Contributor Author

@risicle risicle commented Dec 4, 2019

Good idea.

@risicle
Copy link
Contributor Author

@risicle risicle commented Dec 4, 2019

There already seems to be noise around building with opencv4 dtschump/gmic#166

@jtojnar jtojnar merged commit 3e074a4 into NixOS:master Dec 6, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gmic, gmic-qt on aarch64-linux Success
Details
gmic, gmic-qt on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 6, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.