Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yafaray-core: switch to opencv4 #74370

wants to merge 1 commit into from


Copy link

risicle commented Nov 27, 2019

Motivation for this change

opencv2 is essentially EOL and has security concerns

OpenCV is used for image denoising in yafaray-core

Tested this by rendering the extremely convenient, denoising-enabled test scene provided in the yafaray source , which incidentally would probably be fairly easy to turn into an installCheck in case anyone wanted to have a go - the only tricky thing would be to allow a tolerance of difference against the reference image, due to e.g. image noise.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @Hodapp87

opencv2 is essentially EOL and has security concerns
Copy link

doronbehar commented May 19, 2020

Thanks for the patch @risicle, this was done on #86808 .

@doronbehar doronbehar closed this May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.