Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lego: 3.0.2 -> 3.2.0 #74371

Merged
merged 1 commit into from Dec 5, 2019
Merged

lego: 3.0.2 -> 3.2.0 #74371

merged 1 commit into from Dec 5, 2019

Conversation

@bbigras
Copy link
Contributor

@bbigras bbigras commented Nov 27, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/z9j7v4f265153ark4hvgiq88sgxb33p8-lego-3.0.2 75075032
/nix/store/m0vy2ysbs0vgifwdq4sxza1ab5xm57qs-lego-3.2.0 76082072

Notify maintainers

cc @andrew-d

supersede #72952

Copy link
Contributor

@andrew-d andrew-d left a comment

This works locally, but it looks like there's some internal-only packages getting built and dropped into the bin subdirectory. Could you add the following line?

  subPackages = [ "cmd/lego" ];

Confirmed that everything builds and runs successfully with that ☝️ addition.

@bbigras bbigras force-pushed the bbigras:lego branch from 6206e82 to bedc67f Nov 28, 2019
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Nov 28, 2019

Could you add the following line?
subPackages = [ "cmd/lego" ];

Done. Thanks!

@ofborg ofborg bot requested a review from andrew-d Nov 28, 2019
Copy link
Contributor

@andrew-d andrew-d left a comment

Thank you!

@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Dec 3, 2019

ping @kalbasit

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Dec 4, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/77

@timokau
Copy link
Member

@timokau timokau commented Dec 5, 2019

Thanks!

@timokau timokau merged commit cc6cf0a into NixOS:master Dec 5, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
lego on aarch64-linux Success
Details
lego on x86_64-linux Success
Details
@timokau timokau mentioned this pull request Dec 5, 2019
3 of 10 tasks complete
@bbigras bbigras deleted the bbigras:lego branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.