Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
fplll: 5.2.1 -> 5.3.0, python.pkgs.fpylll: 0.4.1dev -> 0.5.0dev #74372
meta.description for fplll is: '"Lattice algorithms using floating-point arithmetic"'.
meta.homepage for fplll is: '""
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)
18 total rebuild path(s)
6 package rebuild(s)
6 x86_64-linux rebuild(s)
First fifty rebuilds by attrpath
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
cc @7c6f434c for testing.
Fpyll update is not trivial, something has changed with the test setup. I've bisected it to either 327c4c1a3f86c0fc877cfe3e177a3ab3664ece5b or 9732fdb40cf1bd43ad1f60762ec0a8401743fc79.
No time to continue right now. I'll try to get back to it when I have time, but if someone else wants to finish I certainly don't mind ;)
Should be good to go now if @7c6f434c approves of the cleanup commits. If you still prefer the more concise style you used when you created the package, I can revert that change. I just thought that commits like the "clean up dependencies" one have a nicer diff with the new formatting.
The changelog is not ideal, since it links to a search. The project also has a proper changelog, but that has been out of date for a couple of years.
As I consider you more competent than myself here (because of your great Sage work), I don't have any opinions re: style.
(I have read the entire diff and briefly checked the basic reasonability of the added patch)
The two packages need to be updated together, since fpylll 0.4.1 requires the old fplll version and fpylll 0.5.0 requires the new one.
Appreciate the compliment :)
Oh neat, I didn't realise the git tags had release notes as well. I've added that to the list (although they don't seem complete -- for example the latest version doesn't have any release notes there).
Please have another look (just changed the changelogs) and merge if it looks good to you.