Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.ws4py: disabling for python2 #74444

Closed
wants to merge 1 commit into from

Conversation

@d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Nov 28, 2019

Motivation for this change

Due to a planned removal of cherrypy 17, disabling this for
python 2 going forward.

Related to: #73927

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Due to a planned removal of cherrypy 17, disabling this for
python 2 going forward.
@d-goldin d-goldin requested review from FRidh and jonringer as code owners Nov 28, 2019
@d-goldin
Copy link
Contributor Author

@d-goldin d-goldin commented Nov 28, 2019

@GrahamcOfBorg build python3Packages.ws4py

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 28, 2019

what's the motivating reason behind these disables?

@d-goldin
Copy link
Contributor Author

@d-goldin d-goldin commented Nov 28, 2019

@jonringer: specifically this #73927 (comment) from the PR mentioned in the first message.

Edit: so, the intention is to be a bit graceful about the py2 versions. one could of course also leave it and let the message from cherrypy, once deprecated for 2.7, propagate, but eh. I thought explicitness could be nice.

@d-goldin
Copy link
Contributor Author

@d-goldin d-goldin commented Nov 29, 2019

@jonringer: does the explanation make sense or would another approach be better? I was planning to maybe do this for 1-2 more packages.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 30, 2019

It does, but I don't see why we have to be pro-active about removing them if they still build and function as expected.

There's certain packages like sage, which still heavily depend on python2 to function.

Unless there's a pressing reason to disable python2 packages, I'm fine with keeping around frozen versions

@d-goldin
Copy link
Contributor Author

@d-goldin d-goldin commented Nov 30, 2019

@jonringer: There is no pressing reason, its just that cherrypy 17x, which is a dependency of the python 2.7 ws4py has been broken for a while, and the PR linked in the initial issue proposes to deprecate the old version. One of the first issues is that black is incompatible. I went a bit deeper, but there were more issues, that's why the proposal.

@d-goldin
Copy link
Contributor Author

@d-goldin d-goldin commented Dec 20, 2019

Closing, because of lack of interest.

@d-goldin d-goldin closed this Dec 20, 2019
@d-goldin d-goldin deleted the d-goldin:ws4a_disable_py2 branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.