Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: add option to use wolfssl backend #74484

Merged
merged 1 commit into from Dec 10, 2019
Merged

Conversation

@malbarbo
Copy link
Contributor

@malbarbo malbarbo commented Nov 28, 2019

Motivation for this change

Allow smaller closure by using wolfssl backend.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323

@andir
Copy link
Member

@andir andir commented Nov 28, 2019

This should be targeted at the staging branch

"--disable-manual"
( if sslSupport || gnutlsSupport then "--with-ca-fallback" else "--without-ca-fallback")

This comment has been minimized.

@andir

andir Nov 28, 2019
Member

Doesn't this also apply for the wolfssl backend?

This comment has been minimized.

@malbarbo

malbarbo Nov 28, 2019
Author Contributor

The issue here is that wolfssl does not build with --with-ca-fallback, so we only pass --with-ca-fallback for openssl and gnutls.

@malbarbo malbarbo changed the base branch from master to staging Nov 28, 2019
@FRidh FRidh added this to Needs review in Staging Nov 30, 2019
@malbarbo malbarbo force-pushed the malbarbo:curl-wolfssl branch from f5922da to 9b41646 Dec 5, 2019
@malbarbo
Copy link
Contributor Author

@malbarbo malbarbo commented Dec 5, 2019

Added a comment about ca fallback and try to avoid mass rebuild.

@malbarbo
Copy link
Contributor Author

@malbarbo malbarbo commented Dec 5, 2019

Rebuild is not needed anymore. @lovek323 can you take a look?

@FRidh FRidh removed this from Needs review in Staging Dec 10, 2019
@FRidh FRidh merged commit b2b2330 into NixOS:master Dec 10, 2019
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
curl on aarch64-linux Success
Details
curl on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.