Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fzf: fix unstable vim plugin path #74496

Merged
merged 1 commit into from Jan 4, 2020
Merged

Conversation

@midchildan
Copy link
Contributor

@midchildan midchildan commented Nov 28, 2019

Motivation for this change

Make the vim plugin path predictable by not including version numbers in it. I have also bumped the version from 0.18.0 to 0.19.0. (rebased)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@midchildan midchildan changed the title Fix fzf vim plugin path fzf: exclude version number from vim plugin path Nov 28, 2019
@ofborg ofborg bot requested a review from kalbasit Nov 28, 2019
@midchildan midchildan force-pushed the midchildan:fix-fzf-vim-plugin-path branch from b92fbf1 to f7f56bb Jan 4, 2020
exclude version number from vim plugin path
@midchildan midchildan force-pushed the midchildan:fix-fzf-vim-plugin-path branch from f7f56bb to bc213d0 Jan 4, 2020
@midchildan midchildan changed the title fzf: exclude version number from vim plugin path fzf: fix unstable vim plugin path Jan 4, 2020
@ofborg ofborg bot requested review from Br1ght0ne and Ma27 Jan 4, 2020
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

LGTM

@Ma27
Ma27 approved these changes Jan 4, 2020
@Ma27 Ma27 merged commit 502ef3c into NixOS:master Jan 4, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
fzf on aarch64-linux Success
Details
fzf on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@midchildan midchildan deleted the midchildan:fix-fzf-vim-plugin-path branch Jan 12, 2020
midchildan added a commit to midchildan/dotfiles that referenced this pull request Apr 29, 2020
This follows NixOS/nixpkgs#74496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.