Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boxes: init at 1.3 #74515

Merged
merged 2 commits into from Nov 30, 2019
Merged

boxes: init at 1.3 #74515

merged 2 commits into from Nov 30, 2019

Conversation

@waiting-for-dev
Copy link
Contributor

waiting-for-dev commented Nov 28, 2019

Motivation for this change

Adds boxes package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Comments

This is my first derivation, hope everything is fine. I have some doubts about the issue with the system wide config file used in boxes. The file is defined in the Makefile and defaults to /usr/share/boxes. In the derivation I'm changing it for $out/boxes-config. Individual users can define its own config file but, anyway, I'm not sure if there is a better way to go. Also, it would be nice to set the new config file path in a mkDerivation attribute, so that it can be overriden easily if needed. However, if I'm not wrong, I have no way to access $out from there, so it's not possible.

Copy link
Contributor

marsam left a comment

Thanks for your contribution! I left some comments, but LGTM overall

pkgs/tools/text/boxes/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/boxes/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/boxes/default.nix Show resolved Hide resolved
pkgs/tools/text/boxes/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/boxes/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev:boxes branch from 2a79198 to b9b0493 Nov 30, 2019
@waiting-for-dev

This comment has been minimized.

Copy link
Contributor Author

waiting-for-dev commented Nov 30, 2019

Thanks a lot for your review @marsam. I addressed all your comments and forced the push in two commits as you recommended.

@marsam marsam merged commit 65290f9 into NixOS:master Nov 30, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
boxes on aarch64-linux Success
Details
boxes on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@marsam

This comment has been minimized.

Copy link
Contributor

marsam commented Nov 30, 2019

Thanks!

@waiting-for-dev

This comment has been minimized.

Copy link
Contributor Author

waiting-for-dev commented Nov 30, 2019

Thanks for your help @marsam 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.