Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chirp: modernize the expression by using buildPythonApplication #74518

Merged
merged 1 commit into from Dec 12, 2019

Conversation

@andir
Copy link
Member

@andir andir commented Nov 28, 2019

Motivation for this change

I was asked to have a look on this since it apparently broke some time ago.

Things done

I only built the application. Testing has to be done by someone that actually own and uses HAM radio equipment (cc @hax404).

Notify maintainers
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Nov 28, 2019

This ties in with the work in #74295. It doesn't seem there's a port https://chirp.danplanet.com/issues/6327. However it's not a very strong contender for removal, there's actual activity and users https://chirp.danplanet.com/projects/chirp/repository/revisions.

stdenv.mkDerivation rec {
{ stdenv
, fetchurl
, python2

This comment has been minimized.

@FRidh

FRidh Nov 28, 2019
Member

Does it not work with Python 3?

This comment has been minimized.

This comment has been minimized.

@andir

andir Nov 28, 2019
Author Member

The port isn't really complete and has a bunch of issues. Last I checked the first thing I saw was incompatible exception syntax.

@hax404
Copy link
Contributor

@hax404 hax404 commented Dec 12, 2019

Tested programming of Kenwood TH-D72 and Baofeng GT-3 Radio. Works.

@andir andir merged commit b5de0c5 into NixOS:master Dec 12, 2019
16 checks passed
16 checks passed
chirp on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
chirp on aarch64-linux Success
Details
chirp on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.