Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zam-plugins: fix build #74545

Closed
wants to merge 1 commit into from
Closed

zam-plugins: fix build #74545

wants to merge 1 commit into from

Conversation

@corpix
Copy link
Contributor

corpix commented Nov 28, 2019

Motivation for this change

GL/gl.h was removed from mesa package in #72999, needs to be directly imported from libGL now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @magnetophon

GL/gl.h was removed from mesa package in #72999, needs to be directly imported from libGL now
Copy link
Member

magnetophon left a comment

I was just doing the same. :)
The pkg Helm needs it too.

@corpix

This comment has been minimized.

Copy link
Contributor Author

corpix commented Dec 2, 2019

Ok, I see this changes was already merged and helm fixed already :)

@corpix corpix closed this Dec 2, 2019
@corpix corpix deleted the corpix:fix/zam-plugins branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.