Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoTTY: 0.0.13 -> 2.0.0-alpha.3 #74552

Merged
merged 1 commit into from Dec 6, 2019
Merged

GoTTY: 0.0.13 -> 2.0.0-alpha.3 #74552

merged 1 commit into from Dec 6, 2019

Conversation

dermetfan
Copy link
Member

@dermetfan dermetfan commented Nov 29, 2019

Motivation for this change

This version fixes a disconnection error on Firefox (yudai/gotty#249).

It seems there has been no further development for 2 years, so I think the alpha version is ok.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dermetfan dermetfan changed the title gotty: 0.0.13 -> 2.0.0-alpha.3 GoTTY: 0.0.13 -> 2.0.0-alpha.3 Nov 29, 2019
@ofborg ofborg bot requested a review from ehmry November 29, 2019 00:53
ehmry
ehmry approved these changes Dec 6, 2019
@ehmry ehmry merged commit 0fef5b4 into NixOS:master Dec 6, 2019
@dermetfan dermetfan deleted the update/gotty branch December 6, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants