GoTTY: 0.0.13 -> 2.0.0-alpha.3#74552
Merged
1 commit merged intoDec 6, 2019
Merged
Conversation
dermetfan
changed the title
ofborg
Bot
added
10.rebuild-darwin: 1-10
ghost
approved these changes
Dec 6, 2019
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This version fixes a disconnection error on Firefox (yudai/gotty#249).
It seems there has been no further development for 2 years, so I think the alpha version is ok.
Things done
sandboxinnix.confon non-NixOS linux)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)Tested compilation of all pkgs that depend on this change usingnix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Ensured that relevant documentation is up to date