Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmapi: init at v0.0.7 #74657

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@Enteee
Copy link
Contributor

Enteee commented Nov 29, 2019

Motivation for this change

Add the rMAPI client for the reMarkable cloud.

Related pull request to juruen/rmapi

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Enteee Enteee mentioned this pull request Nov 29, 2019
1 of 4 tasks complete
@Enteee Enteee force-pushed the Enteee:feature/add-rmapi-derivation branch 2 times, most recently from 67b4837 to e7785e1 Nov 29, 2019
@Enteee

This comment has been minimized.

Copy link
Contributor Author

Enteee commented Nov 30, 2019

I am struggling to understand / reproduce the CI error.

@Enteee

This comment has been minimized.

Copy link
Contributor Author

Enteee commented Dec 3, 2019

with this

outpath.nix

#!/usr/bin/env nix-shell
# When using as a callable script, passing `--argstr path some/path` overrides $PWD.
#!nix-shell -p nix -i "nix-env -qaP --no-name --out-path --arg checkMeta true --argstr path $PWD -f"
{ checkMeta
, path ? ./.
}:
let
  lib = import (path + "/lib");
  hydraJobs = import (path + "/pkgs/top-level/release.nix")
    # Compromise: accuracy vs. resources needed for evaluation.
    {
      supportedSystems = [
        "aarch64-linux"
        "i686-linux"
        "x86_64-linux"
        "x86_64-darwin"
      ];

      nixpkgsArgs = {
        config = {
          allowBroken = true;
          allowUnfree = true;
          allowInsecurePredicate = x: true;
          checkMeta = checkMeta;

          handleEvalIssue = reason: errormsg:
            let
              fatalErrors = [
                "unknown-meta" "broken-outputs"
              ];
            in if builtins.elem reason fatalErrors
              then abort errormsg
              else true;

          inHydra = true;
        };
      };
    };
  recurseIntoAttrs = attrs: attrs // { recurseForDerivations = true; };

  # hydraJobs leaves recurseForDerivations as empty attrmaps;
  # that would break nix-env and we also need to recurse everywhere.
  tweak = lib.mapAttrs
    (name: val:
      if name == "recurseForDerivations" then true
      else if lib.isAttrs val && val.type or null != "derivation"
              then recurseIntoAttrs (tweak val)
      else val
    );

  # Some of these contain explicit references to platform(s) we want to avoid;
  # some even (transitively) depend on ~/.nixpkgs/config.nix (!)
  blacklist = [
    "tarball" "metrics" "manual"
    "darwin-tested" "unstable" "stdenvBootstrapTools"
    "moduleSystem" "lib-tests" # these just confuse the output
  ];

in
  tweak (builtins.removeAttrs hydraJobs blacklist)

and running:

GC_INITIAL_HEAP_SIZE=4g nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true

I can reproduce the error:

error: cannot import '/nix/store/j6xvkiilmdb23hjxgp3j9pri1qz2w9sc-source/derivation.nix', since path '/nix/store/y74warfhqa098y60zv40v312lf9kfnz5-source.drv' is not valid, at /home/user/workspace/nixpkgs/lib/customisation.nix:119:45
(use '--show-trace' to show detailed location information)

But I still don't understand what goes wrong.

@Enteee Enteee force-pushed the Enteee:feature/add-rmapi-derivation branch from e7785e1 to c840f56 Dec 4, 2019
@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Dec 4, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/is-importing-ad-erivation-from-another-repository-bad-practice/5016/1

@Enteee Enteee force-pushed the Enteee:feature/add-rmapi-derivation branch from c840f56 to 4c70850 Dec 4, 2019
@ofborg ofborg bot requested a review from kalbasit Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.