-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rmapi: init at v0.0.7 #74657
rmapi: init at v0.0.7 #74657
Conversation
67b4837
to
e7785e1
Compare
I am struggling to understand / reproduce the CI error. |
with this outpath.nix
#!/usr/bin/env nix-shell
# When using as a callable script, passing `--argstr path some/path` overrides $PWD.
#!nix-shell -p nix -i "nix-env -qaP --no-name --out-path --arg checkMeta true --argstr path $PWD -f"
{ checkMeta
, path ? ./.
}:
let
lib = import (path + "/lib");
hydraJobs = import (path + "/pkgs/top-level/release.nix")
# Compromise: accuracy vs. resources needed for evaluation.
{
supportedSystems = [
"aarch64-linux"
"i686-linux"
"x86_64-linux"
"x86_64-darwin"
];
nixpkgsArgs = {
config = {
allowBroken = true;
allowUnfree = true;
allowInsecurePredicate = x: true;
checkMeta = checkMeta;
handleEvalIssue = reason: errormsg:
let
fatalErrors = [
"unknown-meta" "broken-outputs"
];
in if builtins.elem reason fatalErrors
then abort errormsg
else true;
inHydra = true;
};
};
};
recurseIntoAttrs = attrs: attrs // { recurseForDerivations = true; };
# hydraJobs leaves recurseForDerivations as empty attrmaps;
# that would break nix-env and we also need to recurse everywhere.
tweak = lib.mapAttrs
(name: val:
if name == "recurseForDerivations" then true
else if lib.isAttrs val && val.type or null != "derivation"
then recurseIntoAttrs (tweak val)
else val
);
# Some of these contain explicit references to platform(s) we want to avoid;
# some even (transitively) depend on ~/.nixpkgs/config.nix (!)
blacklist = [
"tarball" "metrics" "manual"
"darwin-tested" "unstable" "stdenvBootstrapTools"
"moduleSystem" "lib-tests" # these just confuse the output
];
in
tweak (builtins.removeAttrs hydraJobs blacklist) and running:
I can reproduce the error:
But I still don't understand what goes wrong. |
e7785e1
to
c840f56
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/is-importing-ad-erivation-from-another-repository-bad-practice/5016/1 |
c840f56
to
4c70850
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/113 |
# callPackage "${repo}/derivation.nix" { | ||
|
||
callPackage ./derivation.nix { | ||
buildGoModule = super: buildGoModule (super // { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand what's "import from derivation", but I think the meaning is that using simply buildGoModule
as is doesn't work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No that's not what IFS means. I updated the pull request with a link to the wiki which explains IFS derivations. I am nor 100% sure if I should leave this comment or if I should get rid of it entirely.
Co-Authored-By: Doron Behar <doron.behar@gmail.com>
9b8abf5
to
5358f23
Compare
Possibly this pull request is superceded by mine: #85898 That'll teach me to make a PR without searching for it first (again)... |
@NickHu: I have already mentioned this pr on the discourse thread, so I am not quite sure what to do about this so that it can get merged. But I would suggest the following:
what do you think about this? |
replaced by: #85898 |
Motivation for this change
Add the rMAPI client for the reMarkable cloud.
Related pull request to juruen/rmapi
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @