Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
ocamlPackages.nocrypto: Fixed crashes caused by build nondeterminism #74689
Motivation for this change
This package tries to determine cpu capabilities at compile time to use AES-NI instructions. This PR just turns off AES-NI instruction generation altogether. Should I change what I have now to make it easier to override to enable acceleration? If so, how do you think I should do that.
Just to clarify the issue (I don’t have access to the build log): the problem arises if you compile “nocrypto” on a machine that has AES-NI and use the result on a machine that do not have these instructions. This patch always disable the use of AES-NI instructions to be more portable.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: