Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.purescript-psa: init at 0.7.3 #74727

Merged
merged 2 commits into from Dec 20, 2019

Conversation

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Nov 30, 2019

Motivation for this change

Add the purescript-psa package to nodePackages.

This was packaged live during Nix Fridays with @zimbatm.

We followed the steps in the nixpkgs manual (adding purescript-psa to pkgs/development/node-packages/node-packages-v10.json and then running generate.sh).

However, a bunch of files were modified, including pkgs/development/node-packages/node-packages-v12.nix, pkgs/development/node-packages/node-packages-v13.nix, pkgs/development/node-packages/composition-v13.nix, and pkgs/development/node-packages/node-env.nix. I committed them all (since that is what the instructions say to do), but I imagine that might not be the correct thing to do.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@cdepillabout
Copy link
Member Author

@cdepillabout cdepillabout commented Nov 30, 2019

@GrahamcOfBorg build nodePackages.purescript-psa

@@ -2,7 +2,7 @@

{pkgs ? import <nixpkgs> {
inherit system;
}, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-13_x"}:
}, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-8_x"}:

This comment has been minimized.

@cdepillabout

cdepillabout Nov 30, 2019
Author Member

I'm quite worried about this change. It seems strange that generate.sh would replace pkgs.nodejs-13_x with pkgs.nodejs-8_x in this file (since it is composition-v13.nix).

I can remove this change from this PR if necessary.

This comment has been minimized.

@turboMaCk

turboMaCk Dec 2, 2019
Member

this seems like unwanted change to me as well

This comment has been minimized.

@cdepillabout

cdepillabout Dec 2, 2019
Author Member

Yeah, I guess the real question is, is this a problem in node2nix (and should be reported upstream), or is this a problem in the generate.sh script (and a new issue opened here on the nixpkgs repo).

@@ -363,7 +363,7 @@ let
npm ${forceOfflineFlag} --nodedir=${nodeSources} ${npmFlags} ${stdenv.lib.optionalString production "--production"} rebuild
if [ "''${dontNpmInstall-}" != "1" ]

This comment has been minimized.

@zimbatm

zimbatm Dec 1, 2019
Member

This reverts treewide patch: 2811b03

node2nix should be patched to include that change to avoid generating that diff on each run.

This comment has been minimized.

@cdepillabout

cdepillabout Dec 3, 2019
Author Member

This has been reported upstream in svanderburg/node2nix#162.

@adisbladis adisbladis self-assigned this Dec 2, 2019
@turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Dec 2, 2019

bin/psa works as expected to me 👍 It think at least the issue with composition-v13.nix should be resolved though.

@cdepillabout cdepillabout force-pushed the cdepillabout:purescript-psa-node-packages branch from bf6ba62 to 2b63a42 Dec 20, 2019
@cdepillabout
Copy link
Member Author

@cdepillabout cdepillabout commented Dec 20, 2019

@GrahamcOfBorg build purescript-psa pulp

@cdepillabout
Copy link
Member Author

@cdepillabout cdepillabout commented Dec 20, 2019

I never ended up getting a review of this, so I fixed it up as seemed appropriate.

If this ends up causing errors in some other package, let's revert it.

@cdepillabout cdepillabout merged commit b9a83f7 into NixOS:master Dec 20, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pulp, purescript-psa on aarch64-linux Success
Details
pulp, purescript-psa on x86_64-darwin Success
Details
pulp, purescript-psa on x86_64-linux Success
Details
@cdepillabout cdepillabout deleted the cdepillabout:purescript-psa-node-packages branch Dec 20, 2019
@zimbatm
Copy link
Member

@zimbatm zimbatm commented Dec 20, 2019

 ___________ 
< Congrats! >
 ----------- 
       \     (\/)
        \   (_o |
             /  |
             \  \______
              \        )o
               /|----- |
               \|     /|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.