Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.moinmoin: port to python #74753

Merged
merged 1 commit into from Dec 4, 2019
Merged

Conversation

@mmilata
Copy link
Member

@mmilata mmilata commented Nov 30, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Fits CONTRIBUTING.md.
Notify maintainers
machine.wait_for_file("/run/moin/ExampleWiki/gunicorn.sock")
page = machine.succeed("curl -L http://localhost/")
assert re.search(r"If you have just installed", page)

This comment has been minimized.

@tfc

tfc Dec 1, 2019
Contributor

if it is just a plain substring that you need to match, then REs are a big oversided. How about:

Suggested change
assert re.search(r"If you have just installed", page)
assert "If you have just installed" in machine.succeed("curl -L http://localhost/")
out = machine.succeed(
"moin-ExampleWiki account create --name=admin --email=admin@example.com --password=foo 2>&1"
)
assert re.search(r"status success", out)

This comment has been minimized.

@tfc

tfc Dec 1, 2019
Contributor

same here.

@mmilata mmilata force-pushed the mmilata:moinmoin-python-test branch from 5ce3347 to 0168f41 Dec 1, 2019
@mmilata
Copy link
Member Author

@mmilata mmilata commented Dec 1, 2019

@tfc good point, thanks, fixed, PTAL

@tfc
tfc approved these changes Dec 1, 2019
@mmahut
Copy link
Member

@mmahut mmahut commented Dec 4, 2019

@GrahamcOfBorg test moinmoin

@mmahut mmahut merged commit 25f7bd7 into NixOS:master Dec 4, 2019
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.moinmoin on aarch64-linux Success
Details
tests.moinmoin on x86_64-linux Success
Details
@mmilata mmilata deleted the mmilata:moinmoin-python-test branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.