Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "environment.noXlibs: do not pull gobject-introspection" #74760

Merged
merged 2 commits into from Dec 1, 2019

Conversation

@jtojnar
Copy link
Contributor

jtojnar commented Dec 1, 2019

Introspection has nothing to do with GNOME

Reverts #74715

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented Dec 1, 2019

Did you make this with the "revert" button? I'm surprised the commit messages doesn't have the hash of the commit being reverted.

jtojnar added 2 commits Dec 1, 2019
gobject-introspection has nothing to do with graphical systems or GNOME, it is needed for language bindings like Python.

This reverts commit d757135
gobject-introspection has nothing to do with graphical systems or GNOME, it is needed for language bindings like Python.
@jtojnar jtojnar force-pushed the revert-74715-baloo/no-x-libs/polkit branch from de07b7f to 4cb7f43 Dec 1, 2019
@jtojnar

This comment has been minimized.

Copy link
Contributor Author

jtojnar commented Dec 1, 2019

Yup. I also noticed the merge commits are weird. Maybe something to do with Refined GitHub extension.

@jtojnar jtojnar merged commit d7cdd6b into master Dec 1, 2019
15 checks passed
15 checks passed
polkit on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
polkit on aarch64-linux Success
Details
polkit on x86_64-linux Success
Details
@jtojnar jtojnar deleted the revert-74715-baloo/no-x-libs/polkit branch Dec 1, 2019
@matthewbauer

This comment has been minimized.

Copy link
Member

matthewbauer commented Dec 2, 2019

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.