Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dump1090: 2014-10-31 -> 3.7.1 #74771

Merged
merged 2 commits into from Dec 2, 2019
Merged

dump1090: 2014-10-31 -> 3.7.1 #74771

merged 2 commits into from Dec 2, 2019

Conversation

@danieldk
Copy link
Member

danieldk commented Dec 1, 2019

Motivation for this change

The derivation uses an upstream for dump1090 that has not been updated
since 2014. FlightAware seems to have the most actively maintained
version of dump1090, so this change switches to FlightAware's
version, bringing 5 years of improvements.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @earldouglas

@ofborg ofborg bot requested a review from earldouglas Dec 1, 2019
@markuskowa markuskowa self-assigned this Dec 1, 2019
@markuskowa

This comment has been minimized.

Copy link
Member

markuskowa commented Dec 1, 2019

The flight aware dump1090 is the definitely the better version. It is worth mentioning that this version does not have an internal web server anymore, which is a breaking change. Given that the derivation has been untouched since 2014 it is probably safe to assume that this will not affect too many users. Would you mind putting a comment in the release notes?

@danieldk

This comment has been minimized.

Copy link
Member Author

danieldk commented Dec 1, 2019

The flight aware dump1090 is the definitely the better version. It is worth mentioning that this version does not have an internal web server anymore, which is a breaking change. Given that the derivation has been untouched since 2014 it is probably safe to assume that this will not affect too many users. Would you mind putting a comment in the release notes?

Good point! I'll add a commit adding a blurb to the release notes to this PR later.

Copy link
Contributor

earldouglas left a comment

Thanks!

danieldk added 2 commits Dec 1, 2019
The derivation uses an upstream for dump1090 that has not been updated
since 2014. FlightAware seems to have the most actively maintained
version of dump1090, so this change switches to FlightAware's
version, bringing 5 years of improvements.
@danieldk danieldk force-pushed the danieldk:dump1090-3.7.2 branch from 3dda28f to 02553c1 Dec 2, 2019
@danieldk

This comment has been minimized.

Copy link
Member Author

danieldk commented Dec 2, 2019

Added a commit that adds a blurb to the release notes.

@markuskowa markuskowa merged commit 0804fd6 into NixOS:master Dec 2, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
dump1090 on aarch64-linux Success
Details
dump1090 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.