Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pykde4: drop #74772

Merged
merged 1 commit into from Dec 1, 2019
Merged

pythonPackages.pykde4: drop #74772

merged 1 commit into from Dec 1, 2019

Conversation

@gnidorah
Copy link
Member

gnidorah commented Dec 1, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@gnidorah gnidorah requested review from FRidh and jonringer as code owners Dec 1, 2019
@ofborg ofborg bot added the 6.topic: python label Dec 1, 2019
@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Dec 1, 2019

@gnidorah it's time to get rid of this package in Nixpkgs. It's on the old openssl, old phonon, and old qt4 which is going to be removed (#33248). I highly doubt anyone but you is using this package.

@gnidorah

This comment has been minimized.

Copy link
Member Author

gnidorah commented Dec 1, 2019

@FRidh I think you're right, its gone too messy. I will add a commit to drop a package

@gnidorah gnidorah force-pushed the gnidorah:pykde4 branch from 4b0b52f to 7ee8171 Dec 1, 2019
@gnidorah gnidorah changed the title pythonPackages.pykde4: fix build pythonPackages.pykde4: drop Dec 1, 2019
@FRidh FRidh merged commit 784914c into NixOS:master Dec 1, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@gnidorah

This comment has been minimized.

Copy link
Member Author

gnidorah commented Dec 1, 2019

@FRidh Thank you!

@gnidorah gnidorah deleted the gnidorah:pykde4 branch Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.