Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fido2luks: init at 0.2.2 #74780

Merged
merged 1 commit into from Jan 12, 2020
Merged

fido2luks: init at 0.2.2 #74780

merged 1 commit into from Jan 12, 2020

Conversation

@prusnak
Copy link
Member

prusnak commented Dec 1, 2019

Motivation for this change

New package allowing to use of FIDO2 tokens for LUKS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@prusnak prusnak force-pushed the prusnak:fido2luks branch from 185e645 to df24b0c Dec 1, 2019
@prusnak prusnak changed the title fido2: init at unstable-2019-10-12 fido2luks: init at unstable-2019-10-12 Dec 1, 2019
Copy link
Member

Ekleog left a comment

A single nit on the implementation.

However, on the idea… This software appears to have been released once, in beta only (without any tag), two months ago on reddit, and to have seen no change since then -- hinting at little maintenance, though this is by no means a definitive answer.

I'm not opposed to including it, if it solves a problem that no other software currently solves. But I want to check: if you have the hardware it appears designed to work with, have you actually already tested it locally? Does it work properly? Does it have issues, or is it the “perfect” piece of software its 0 issues would let one assume?

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@prusnak prusnak force-pushed the prusnak:fido2luks branch from df24b0c to 2aeb433 Dec 15, 2019
@prusnak

This comment has been minimized.

Copy link
Member Author

prusnak commented Dec 15, 2019

@Ekleog Good points. I did the initial packaging so my colleague could test it. Let's keep this open and wait until we properly test it.

@Ekleog

This comment has been minimized.

Copy link
Member

Ekleog commented Dec 15, 2019

Great, thanks! I found this through triage, and there's a risk I completely forget about it, so when you've tested it, don't hesitate to ping me on freenode#nixos

@prusnak prusnak force-pushed the prusnak:fido2luks branch from 2aeb433 to 330df9f Jan 2, 2020
@mmahut mmahut mentioned this pull request Jan 10, 2020
2 of 10 tasks complete
@prusnak prusnak force-pushed the prusnak:fido2luks branch from fc8af26 to 7f44482 Jan 11, 2020
@prusnak prusnak changed the title fido2luks: init at unstable-2019-10-12 fido2luks: init at 0.2.2 Jan 11, 2020
@ofborg ofborg bot requested a review from mmahut Jan 11, 2020
@prusnak prusnak force-pushed the prusnak:fido2luks branch from 7f44482 to 865fc6c Jan 11, 2020
@prusnak prusnak requested a review from Ekleog Jan 11, 2020
@prusnak

This comment has been minimized.

Copy link
Member Author

prusnak commented Jan 11, 2020

I am in contact with the developer and he is eager to keep developing this. In fact, he just published a new stable release on Github which is packaged here. @mmahut is a co-maintainer and will try to integrate this with NixOS.

@Ekleog Ekleog dismissed their stale review Jan 11, 2020

Outdated

@Ekleog
Ekleog approved these changes Jan 11, 2020
Copy link
Member

Ekleog left a comment

This LGTM, but I'll let @mmahut handle the decision to merge, as he seems involved :)

@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Jan 12, 2020

Thanks, verified the package works fine.

Now the fun part, integration :)

@mmahut mmahut merged commit 48b537e into NixOS:master Jan 12, 2020
16 checks passed
16 checks passed
fido2luks on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
fido2luks on aarch64-linux Success
Details
fido2luks on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@prusnak prusnak deleted the prusnak:fido2luks branch Jan 12, 2020
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 12, 2020
fido2luks: init at 0.2.2
(cherry picked from commit 48b537e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.